-
-
Notifications
You must be signed in to change notification settings - Fork 0
chore(deps): bump dependency versions #508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Azure.Identity 1.13.* → 1.17.* - Microsoft.Extensions.* 10.0.1 → 10.0.2 - actions/setup-node v4 → v6 - actions/upload-artifact v4 → v6 Co-Authored-By: Claude Opus 4.5 <[email protected]>
Summary of ChangesHello @joshsmithxrm, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on maintaining the project's health and security by updating several core dependencies to their latest stable versions. The updates encompass a significant bump for Azure authentication libraries and minor version increments for various Microsoft Extension packages, which collectively enhance stability, performance, and address known vulnerabilities. This consolidation streamlines multiple dependency updates into a single, manageable change. Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates several dependencies across the solution, including Azure.Identity and various Microsoft.Extensions.* packages. The changes are straightforward version bumps. My review includes a suggestion to pin the Azure.Identity package to a specific version to ensure reproducible builds, which is a common best practice for dependency management. The other dependency updates look good.
src/PPDS.Auth/PPDS.Auth.csproj
Outdated
| <ItemGroup> | ||
| <!-- Azure Identity for OIDC and DefaultAzureCredential --> | ||
| <PackageReference Include="Azure.Identity" Version="1.13.*" /> | ||
| <PackageReference Include="Azure.Identity" Version="1.17.*" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To improve build reproducibility and prevent unexpected changes, it's a best practice to pin package versions to a specific version instead of using wildcards. This ensures that everyone on the team and in CI/CD pipelines uses the exact same version of the dependency. Please consider pinning Azure.Identity to a specific version, such as 1.17.0.
<PackageReference Include="Azure.Identity" Version="1.17.0" />
Co-Authored-By: Claude Opus 4.5 <[email protected]>
Replaces wildcard versions with exact versions: - Azure.Identity 1.17.1 - Dataverse.Client 1.2.10 - System.Text.Json 9.0.12 - System.IdentityModel.Tokens.Jwt 8.3.1 - Spectre.Console 0.54.0 - Terminal.Gui 1.19.0 - Moq 4.20.72 - StreamJsonRpc 2.22.23 Co-Authored-By: Claude Opus 4.5 <[email protected]>
Summary
Consolidates dependabot PRs #494, #495, #496, #498, #499, #505, #506.
Test plan
🤖 Generated with Claude Code