add pedantic clippy setting and fix/allow warnings (#147)

Author: joshuadavidthomas

.github/workflows/lint.yml

@@ -26,12 +26,6 @@ jobs:
         with:
           persist-credentials: false
 
-      - name: Install nightly toolchain for rustfmt
-        uses: dtolnay/rust-toolchain@b3b07ba8b418998c39fb20f53e8b695cdcc8de1b
-        with:
-          toolchain: nightly
-          components: rustfmt
-
       - name: Install uv
         uses: astral-sh/setup-uv@6b9c6063abd6010835644d4c2e1bef4cf5cd0fca  # v6.0.1
         with:
@@ -49,3 +43,44 @@ jobs:
             --all-files \
             --show-diff-on-failure \
             --color always
+
+  rustfmt:
+    runs-on: ubuntu-24.04
+    steps:
+      - uses: actions/checkout@v4
+        with:
+          persist-credentials: false
+
+      - uses: actions-rust-lang/setup-rust-toolchain@9d7e65c320fdb52dcd45ffaa68deb6c02c8754d9
+        with:
+          toolchain: nightly
+          components: rustfmt
+
+      - name: Run rustfmt
+        run: cargo +nightly fmt --all -- --check
+
+  clippy:
+    runs-on: ubuntu-24.04
+    steps:
+      - uses: actions/checkout@v4
+        with:
+          persist-credentials: false
+
+      - uses: actions-rust-lang/setup-rust-toolchain@9d7e65c320fdb52dcd45ffaa68deb6c02c8754d9
+        with:
+          components: clippy
+
+      - name: Run clippy
+        run: cargo clippy --all-targets --all-features -- -D warnings
+
+  cargo-check:
+    runs-on: ubuntu-24.04
+    steps:
+      - uses: actions/checkout@v4
+        with:
+          persist-credentials: false
+
+      - uses: actions-rust-lang/setup-rust-toolchain@9d7e65c320fdb52dcd45ffaa68deb6c02c8754d9
+
+      - name: Run cargo check
+        run: cargo check --all-targets --all-features

.pre-commit-config.yaml

@@ -1,6 +1,3 @@
-default_language_version:
-  rust: "1.86"
-
 repos:
   - repo: https://github.com/pre-commit/pre-commit-hooks
     rev: v5.0.0
@@ -21,30 +18,3 @@ repos:
     rev: v1.6.0
     hooks:
     - id: zizmor
-  - repo: local
-    hooks:
-      - id: fmt
-        name: cargo fmt
-        description: format files with "cargo fmt"
-        types:
-          - rust
-        language: rust
-        entry: cargo +nightly fmt
-        args:
-          - --
-      - id: check
-        name: cargo check
-        description: check the package for errors with "cargo check"
-        types:
-          - rust
-        language: rust
-        entry: cargo check
-        pass_filenames: false
-      - id: clippy
-        name: cargo clippy
-        description: check the package with "cargo clippy"
-        types:
-          - rust
-        language: rust
-        entry: cargo clippy
-        pass_filenames: false

Cargo.toml

@@ -23,6 +23,10 @@ thiserror = "2.0"
 tokio = { version = "1.42", features = ["full"] }
 tower-lsp-server = { version = "0.21", features = ["proposed"] }
 
+[workspace.lints.clippy]
+pedantic = { level = "warn", priority = -1 }
+missing_errors_doc = "allow"
+
 [profile.dev.package]
 insta.opt-level = 3
 similar.opt-level = 3

crates/djls-conf/Cargo.toml

@@ -14,3 +14,6 @@ toml = "0.8"
 
 [dev-dependencies]
 tempfile = "3.19"
+
+[lints]
+workspace = true

crates/djls-conf/src/lib.rs

@@ -79,10 +79,12 @@ impl Settings {
         Ok(settings)
     }
 
+    #[must_use]
     pub fn debug(&self) -> bool {
         self.debug
     }
 
+    #[must_use]
     pub fn venv_path(&self) -> Option<&str> {
         self.venv_path.as_deref()
     }

crates/djls-dev/Cargo.toml

@@ -6,3 +6,6 @@ publish = false
 
 [dependencies]
 pyo3-build-config = { workspace = true, features = ["resolve-config"] }
+
+[lints]
+workspace = true

crates/djls-dev/src/build.rs

@@ -31,7 +31,7 @@ pub fn setup_python_linking() {
     // Only link libpython explicitly if we are NOT building an extension module.
     if !is_extension_module {
         if let Some(lib_name) = &config.lib_name {
-            println!("cargo:rustc-link-lib=dylib={}", lib_name);
+            println!("cargo:rustc-link-lib=dylib={lib_name}");
         } else {
             // Warn only if linking is actually needed but we can't find the lib name
             println!("cargo:warning=Python library name not found in config (needed for non-extension module
@@ -43,9 +43,9 @@ builds).");
     // These are needed for test executables and potential future standalone binaries,
     // and generally harmless for extension modules.
     if let Some(lib_dir) = &config.lib_dir {
-        println!("cargo:rustc-link-search=native={}", lib_dir);
+        println!("cargo:rustc-link-search=native={lib_dir}");
         #[cfg(not(windows))]
-        println!("cargo:rustc-link-arg=-Wl,-rpath,{}", lib_dir);
+        println!("cargo:rustc-link-arg=-Wl,-rpath,{lib_dir}");
     } else {
         // Warn only if linking is actually needed but we can't find the lib dir
         if !is_extension_module {

crates/djls-project/Cargo.toml

@@ -19,3 +19,6 @@ djls-dev = { workspace = true }
 
 [dev-dependencies]
 tempfile = { workspace = true }
+
+[lints]
+workspace = true

crates/djls-project/src/lib.rs

@@ -23,6 +23,7 @@ pub struct DjangoProject {
 }
 
 impl DjangoProject {
+    #[must_use]
     pub fn new(path: PathBuf) -> Self {
         Self {
             path,
@@ -64,17 +65,19 @@ impl DjangoProject {
                     Ok(())
                 }
                 Err(e) => {
-                    eprintln!("Failed to import Django: {}", e);
+                    eprintln!("Failed to import Django: {e}");
                     Err(e)
                 }
             }
         })
     }
 
+    #[must_use]
     pub fn template_tags(&self) -> Option<&TemplateTags> {
         self.template_tags.as_ref()
     }
 
+    #[must_use]
     pub fn path(&self) -> &Path {
         &self.path
     }
@@ -84,7 +87,7 @@ impl fmt::Display for DjangoProject {
     fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
         writeln!(f, "Project path: {}", self.path.display())?;
         if let Some(py_env) = &self.env {
-            write!(f, "{}", py_env)?;
+            write!(f, "{py_env}")?;
         }
         Ok(())
     }
@@ -141,7 +144,7 @@ mod tests {
 
         let project = DjangoProject::new(project_path.clone());
 
-        let display_str = format!("{}", project);
+        let display_str = format!("{project}");
         assert!(display_str.contains(&format!("Project path: {}", project_path.display())));
     }
 }

crates/djls-project/src/python.rs

@@ -96,9 +96,8 @@ impl PythonEnvironment {
     }
 
     fn from_system_python() -> Option<Self> {
-        let python_path = match system::find_executable("python") {
-            Ok(p) => p,
-            Err(_) => return None,
+        let Ok(python_path) = system::find_executable("python") else {
+            return None;
         };
         let bin_dir = python_path.parent()?;
         let prefix = bin_dir.parent()?;