Skip to content

Conversation

@serl
Copy link
Contributor

@serl serl commented Feb 19, 2025

Fixes #61.

Hello, just passed by this promising repo, saw the ❌ on main, found #61 and wanted to contribute.

At work, we have some local hooks in our pre-commit configuration (which depend on the installed deps on the project), and we run it directly in GitHub Actions similarly to this.
I guess that this could help, if not, feel free to close this PR.

Extra bits:

Have a nice day!

EDIT:
Ah forgot to mention that I don't really know how the concurrency thing interacts with this new job

@joshuadavidthomas
Copy link
Owner

@serl Very cool! Thank for the contribution. Sorry it's taken a bit to give you some eyes on this.

I have the pre-commit.ci GitHub App installed for the repo, but as you can see it doesn't quite work with Rust and cargo apparently? My searching abilities are failing me because I cannot find the right way to make sure cargo is available in their CI, so this workflow is perfect.

@joshuadavidthomas joshuadavidthomas merged commit 6873b3f into joshuadavidthomas:main Mar 10, 2025
20 of 21 checks passed
@serl
Copy link
Contributor Author

serl commented Mar 10, 2025

@serl Very cool! Thank for the contribution. Sorry it's taken a bit to give you some eyes on this.

I have the pre-commit.ci GitHub App installed for the repo, but as you can see it doesn't quite work with Rust and cargo apparently? My searching abilities are failing me because I cannot find the right way to make sure cargo is available in their CI, so this workflow is perfect.

Fantastic! Glad to be helpful 🙂
I guess now the last thing to kill that ❌ would be to disconnect pre-commit GitHub App from this repo 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix pre-commit

2 participants