Skip to content

linter first pass#7

Open
akhenakh wants to merge 1 commit intojoshuaferrara:masterfrom
akhenakh:linterpass1
Open

linter first pass#7
akhenakh wants to merge 1 commit intojoshuaferrara:masterfrom
akhenakh:linterpass1

Conversation

@akhenakh
Copy link
Contributor

First pass at Go linters, also see #5

tests are passing

@joshuaferrara
Copy link
Owner

See my comment in #5 , but the gist of some of these unused variables seems to be that they're actually meant to be outputs of the function. Rather than deleting these, we should return them and set values appropriately wherever these functions are called. It'd be best to look over the C++ source code (specifically sgp4unit.cpp) at https://www.celestrak.com/publications/AIAA/2006-6753/ and modify the call/returns of functions where necessary such that the output values are piped throughout the algorithm correctly. This was a total oversight on younger-me's part...ugh.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants