Fix RuntimeWarning: divide by zero in retracement calculation#99
Merged
joshyattridge merged 1 commit intojoshyattridge:masterfrom Apr 3, 2026
Merged
Conversation
Add zero-division guard when calculating current_retracement for both bullish (direction == 1) and bearish (direction == -1) cases. When top == bottom, the retracement is set to 0 instead of causing a RuntimeWarning. Fixes joshyattridge#33 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Contributor
Author
|
Hi! Just checking in on this fix for the divide-by-zero warning. Happy to make any adjustments if needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the divide by zero warning in
fib_retracements()whentop == bottom.Problem
Solution
Add a guard to check if the divisor is zero before performing division:
top - bottom != 0bottom - top != 0When the divisor is zero, return 0 as the retracement value.
Changes
Fixes #33
🤖 Generated with Claude Code