Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the draft release workflow to align it with the Flutter-based approach used consistently across other workflows in the repository. The workflow previously used the standalone Dart SDK setup but now properly uses Flutter SDK setup, and also removes unnecessary branch management steps.
Changes:
- Updated workflow name from "Create Release" to "Draft Release"
- Replaced
dart-lang/setup-dart@v1withsubosito/flutter-action@v2for SDK setup - Removed redundant branch checkout and pull steps since the workflow runs in a clean environment
- Added caching to the Flutter setup step
Comments suppressed due to low confidence (1)
.github/workflows/draft-release.yml:18
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Deploying flutter-maplibre with
|
| Latest commit: |
9e7a807
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://740aa745.flutter-maplibre.pages.dev |
| Branch Preview URL: | https://chore-fix-draft-release-work.flutter-maplibre.pages.dev |
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (3)
.github/workflows/draft-release.yml:31
- The version is hardcoded to '0.3.3+1' instead of using the workflow input variable. This should use
${{ inputs.version }}to work correctly with the workflow_dispatch trigger.
.github/workflows/draft-release.yml:37 - When the workflow is triggered by pull_request,
inputs.versionwill be empty, causing the tag_name and name to be just 'v'. The workflow should either skip the release creation step on PR triggers or provide a default/test version value.
.github/workflows/draft-release.yml:28 - The description mentions that Flutter users should use
flutter pubinstead ofdart pub, but the workflow still usesdart pub get. This should be changed toflutter pub getto be consistent with the PR's stated purpose and avoid potential dependency resolution issues.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because maplibre_ios_example requires the Flutter SDK, version solving failed. Flutter users should useflutter pubinstead ofdart pub.