Conversation
# Conflicts: # klog/app/cli/args/filter.go # klog/app/cli/args/now.go # klog/app/cli/args/warn.go # klog/service/warning.go
Merged
jotaen
added a commit
that referenced
this pull request
Feb 22, 2026
v7.0...main - #412 - #414 - #415
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR restores the pre-v7.0 behaviour where the filters would keep empty records if they match the filter. E.g.,
--period 2000-01, all records match.--tag foo, both2000-01-02and the1hentry in2000-01-03match.--tag bar, only the2hentry in2000-01-03matches.--tag asdf, nothing matches.Also, this PR introduces a new warning: if you apply entry-level filtering (resulting in partial records) and do
--diff, it warns you that the result may be nonsensical. The reason is that the should-total always applies to the entire record. The warning(s) can be disabled in the config file or via the--no-warnflag.Related #410.