Fix bug for resubscribers with newsletter

Author: rossta

app/controllers/users/newsletter_subscriptions_controller.rb

@@ -26,10 +26,8 @@ def new
 
   def create
     create_user_params = params.require(:user).permit(:email)
-    @user = User.find_or_initialize_by(email: create_user_params[:email]) do |u|
-      u.subscribing = true
-    end
-
+    @user = User.find_or_initialize_by(email: create_user_params[:email])
+    @user.subscribing = true
     @newsletter_subscription = @user.newsletter_subscription || @user.build_newsletter_subscription
 
     @user.save

spec/factories/users.rb

@@ -22,6 +22,11 @@
       password_confirmation { nil }
     end
 
+    trait :subscriber do
+      subscribing
+      newsletter_subscription
+    end
+
     trait :subscribed do
       newsletter_subscription
     end

spec/requests/users/newsletter_subscriptions_spec.rb

@@ -95,7 +95,7 @@
     end
 
     it "disallows for a subscribing with an already subscribed email" do
-      user = FactoryBot.create(:user, :subscribed)
+      user = FactoryBot.create(:user, :subscriber)
 
       expect {
         post users_newsletter_subscriptions_path,