WIP: Feature/fast scroll mute#267
Open
tobymitico wants to merge 5 commits intojpbruinsslot:masterfrom
Open
Conversation
…s to just make it compile, not tested at all. channel mark reads may not be working
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I read contributing.md and I'm fully aware this may not be merging as is. I'm happy to make this PR a discussion and implement requested changes as we go.
this PR helped me get slack-term a lot more usable on a slightly bigger workspace (aka long channel list and lots of notifications).
in a nutshell this PR adds:
all of the above works but was just a quick and dirty way to get this going for me and read/learn the code base, but before I spend more time cleaning this up, I figured I start this discussion....
also what I'd still really like to find/fix is a way to limit the direct DM contacts in the channels list to those that are actually still open. it seems like none of the fields provided by the API identifies those?!?!. it seems any Contact every contacted is listed and that makes this list way longer than it needs to be.