iOS: Update collection view layout for a better looking grid#1151
Open
yoshisuga wants to merge 4 commits intojpd002:masterfrom
Open
iOS: Update collection view layout for a better looking grid#1151yoshisuga wants to merge 4 commits intojpd002:masterfrom
yoshisuga wants to merge 4 commits intojpd002:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Games list screen had some wasted space in the middle, where the items would be pinned to the leading and trailing edges of the collection view.
Updated to use the UICollectionView compositional layout API to better support a grid layout. It also supports iPad using the trait collections/size class. This API however requires iOS 13. (PR: jpd002/Play-Dependencies#29)
Also updated the collection view cell to use auto layout constraints for the label.