Skip to content

Update endpoints.py #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lalo-uy wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update endpoints.py #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions modules/logs/endpoints.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,15 +87,17 @@ def read_log_as_json(self, log_type, log_id): # pylint: disable=no-self-use
array = []
with open(filename, 'r', encoding='utf-8') as csv_file:
reader = csv.reader(csv_file)
l_time=0
for row in reader:
try:
array.append([
int((datetime.datetime.strptime(
row[0], "%Y-%m-%d %H:%M:%S") -
datetime.datetime(1970, 1, 1)).total_seconds()) *
1000,
float(row[1])
])
p_time=int((datetime.datetime.strptime( # get point timestamp
row[0], "%Y-%m-%d %H:%M:%S") -
datetime.datetime(1970, 1, 1)).total_seconds()) * 1000
if ( abs(float(row[1])) < 110 ) and # filter invalid points
( p_time >= l_time ): # only plot if more than 60 sec from previus point
Copy link
Owner

@jpgimenez jpgimenez Aug 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea, but IMO should be configurable...

Copy link
Author

@lalo-uy lalo-uy Aug 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean the enable/disable or the time interval ( 60 sec )?

Copy link

@staticdev staticdev Oct 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lalo-uy I think you could have a parameter plot_period to configure that and have the default of 60.

So you replace the line: l_time = p_time + 60000;
With: l_time = p_time + 1000 * cbpi.get_config_parameter("plot_period", 60)

It that what you meant @jpgimenez?

Copy link
Owner

@jpgimenez jpgimenez Oct 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 agree... the parameter is better than a hardcoded value

l_time = p_time + 60000;
array.append([p_time , float(row[1])])

except IndexError:
pass
return array
Expand Down