reverse_named_url fails on Django 1.5 if using url arguments#23
Open
SpectralAngel wants to merge 1 commit intojphalip:masterfrom
Open
reverse_named_url fails on Django 1.5 if using url arguments#23SpectralAngel wants to merge 1 commit intojphalip:masterfrom
SpectralAngel wants to merge 1 commit intojphalip:masterfrom
Conversation
Owner
|
Hello and thanks for the patch. If you could provide a test, that would be great. That would also clarify the issue you've run into. Cheers! |
|
I'm trying this patch and it works for me with django 1.5.1. |
|
https://docs.djangoproject.com/en/1.8/ref/templates/builtins/#std:templatetag-url try to use 'url' to replace 'reverse_named_url' :) just like : |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While migrating an app to Django 1.5 one of my menus handled by treemenus started to fail, it was looking for an url named this way:
"my_awesome_url its_awesome_argument"
All as a single url, this commit fixes that, but i owe you a test case.