test: add schema-gated full lifecycle integration test#49
Merged
Conversation
Validates complete schema-gated progression (queue→work→review→terminal) with gate enforcement at each transition. Tests both feature-implementation and bug-fix schemas, schema-free mode, empty note body rejection, and the complete trigger requiring all phase notes. 5 test cases using H2 in-memory database + real repositories (not mocks) with inline NoteSchemaService mirroring production config.yaml schemas. MCP item: e926961c-e029-493d-b820-4054e34efc9a Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…nsistency checks Adds 6 new test cases (11 total) targeting complex scenarios that could expose response/DB inconsistencies: - Child start cascading parent to work (with response verification) - Parent with schema tag — cascade bypasses start-trigger gate - Batch transitions with mixed gate outcomes (pass/fail/schema-free) - Full lifecycle with parent cascade and response/DB consistency at every step - Rapid sequential note fills and advances - Multiple children with different schemas under shared parent Introduces assertResponseMatchesDb() helper that verifies advance_item response matches actual DB state after each transition. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Adds mixed-schema tag with required + optional notes per phase, including a review phase with only optional notes. 4 new test cases: - Gate only blocks on required notes, ignores optional - Review phase with only optional notes advances freely - Complete trigger only checks required notes across all phases - Filling optional note does not satisfy required note gate 15 total tests in SchemaGatedLifecycleTest. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SchemaGatedLifecycleTest(338 lines, 5 test cases) validating the complete schema-gated workflow lifecyclefeature-implementationandbug-fixschemascompletetrigger requiring all phase notesTest Results
Review
Independent review passed — all acceptance criteria met, tests are substantive (none pass with gates removed), code follows existing WorkflowIntegrationTest patterns.
MCP Items
e926961c— Schema-gated full lifecycle integration test🤖 Generated with Claude Code