docs(workflow): add repo-local authority evidence pack#77
docs(workflow): add repo-local authority evidence pack#77hu3mann wants to merge 1 commit intojpicklyk:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a repo-local “workflow authority evidence pack” under pm-workflow-pack/ to document, with citations and recorded negative-evidence searches, what the repository’s active/current workflow implementation persists, enforces, exposes, and does not contain (within the scanned scope).
Changes:
- Introduces a structured documentation pack covering scan method, entity/persistence model, legality rules, gates/read models, history surfaces, runtime variants/split-brain risks, and integration seams.
- Adds a repo-local authority verdict summarizing what the repo is authoritative for vs. absent (based on the included evidence).
- Adds an evidence index capturing primary citations and explicit negative-evidence search commands/results.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| pm-workflow-pack/00-scan-scope-and-method.md | Defines scan scope, commands used, and the negative-evidence method. |
| pm-workflow-pack/01-entity-and-persistence-model.md | Documents core entities, schema alignment, and reader/writer surfaces in current/. |
| pm-workflow-pack/02-workflow-legality-and-transition-analysis.md | Describes legality model, validated transition path, and bypass mutation paths. |
| pm-workflow-pack/03-gates-actions-and-progress.md | Classifies gates and advisory computations; records absence of decision/progress subsystems. |
| pm-workflow-pack/04-audit-history-and-chronicle.md | Details transition audit trail, exposed history surfaces, and absence of a chronicle/event store. |
| pm-workflow-pack/05-runtime-variants-and-local-split-brain-risks.md | Analyzes selector drift and competing runtimes/writers as local split-brain risks. |
| pm-workflow-pack/06-integration-seams.md | Summarizes MCP tool surface, container/runtime seams, config seams, and plugin/hook surfaces. |
| pm-workflow-pack/07-repo-local-authority-verdict.md | Provides a consolidated repo-local authority verdict grounded in cited code/schema. |
| pm-workflow-pack/99-evidence-index.md | Central index of citations plus negative-evidence searches and validation attempts. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - `CLAUDE.md` and `AGENTS.md` still point at a non-existent bundled `default-config.yaml` | ||
|
|
||
| Systems/components involved: | ||
| - `YamlNoteSchemaService` | ||
| - `NoteSchemaService` | ||
| - `current/docs/*` | ||
| - `CLAUDE.md` | ||
| - `AGENTS.md` |
There was a problem hiding this comment.
This section treats AGENTS.md as a source of repo-local guidance and cites line ranges, but AGENTS.md is not present in the repository tree in this PR. To keep the evidence pack auditable, either commit AGENTS.md or remove/replace the references/citations to it.
|
|
||
| ## Negative-Evidence Searches | ||
|
|
||
| Each search below was run from `/Users/hue/code/task-orchestrator`. |
There was a problem hiding this comment.
The evidence index records the working directory as an absolute local path (/Users/hue/...). For portability and to avoid leaking local username details, record this as “run from repo root” (or use a placeholder like <repo-root>) instead.
| Each search below was run from `/Users/hue/code/task-orchestrator`. | |
| Each search below was run from the repository root (`<repo-root>`). |
| - `clockwork/src/main/kotlin/io/github/jpicklyk/mcptask/application/tools/status/RequestTransitionTool.kt:21-42,43-45` | ||
| - `clockwork/src/main/kotlin/io/github/jpicklyk/mcptask/application/tools/status/QueryRoleTransitionsTool.kt:14-20,21-32,36-43` | ||
| - `CLAUDE.md:124-132` | ||
| - `AGENTS.md:124-132` |
There was a problem hiding this comment.
This primary source index cites AGENTS.md:124-132, but AGENTS.md is not present in the repository tree in this PR. Either add AGENTS.md to the repo or remove/replace these citations so readers can audit them.
| - `AGENTS.md:124-132` |
| ```bash | ||
| rg -n 'default-config.yaml|\\.taskorchestrator/config.yaml|AGENT_CONFIG_DIR' \ | ||
| current/docs CLAUDE.md AGENTS.md current/src/main/kotlin | ||
| ``` | ||
|
|
||
| Scope: | ||
| - `current/docs` | ||
| - `CLAUDE.md` | ||
| - `AGENTS.md` | ||
| - `current/src/main/kotlin` | ||
|
|
||
| Result: | ||
| - root docs refer to both `AGENT_CONFIG_DIR` and `.taskorchestrator/config.yaml` | ||
| - `CLAUDE.md:131` and `AGENTS.md:131` also refer to `current/src/main/resources/configuration/default-config.yaml` | ||
| - runtime code resolves `.taskorchestrator/config.yaml` |
There was a problem hiding this comment.
Negative search N8 includes AGENTS.md in the command/scope and references AGENTS.md:131, but the file is not present in the repository. To keep the negative-evidence trail reproducible, remove AGENTS.md from this search (or commit the file) and adjust the result notes accordingly.
| nl -ba current/src/main/kotlin/.../CurrentMain.kt | sed -n '9,46p' | ||
| nl -ba current/src/main/kotlin/.../CurrentMcpServer.kt | sed -n '38,223p' | ||
| nl -ba current/src/main/resources/db/migration/V1__Current_Initial_Schema.sql | sed -n '1,140p' | ||
| nl -ba current/src/main/resources/db/migration/V2__Work_Item_Field_Updates.sql | sed -n '1,140p' |
There was a problem hiding this comment.
The “Representative inspection commands” block uses ... placeholders in paths (e.g., current/src/main/kotlin/.../CurrentMain.kt), which makes the commands non-reproducible if copy/pasted. Consider replacing these with the concrete paths used elsewhere in the pack (or explicitly label them as placeholders and point to the exact files).
|
|
||
| ## Scope | ||
|
|
||
| This pack was produced from repo-local evidence in `/Users/hue/code/task-orchestrator` only. |
There was a problem hiding this comment.
The scan scope is anchored to a machine-specific absolute path (/Users/hue/...). This makes the pack less portable and can leak local username details. Consider rewriting this to “run from the repo root” (or a placeholder like <repo-root>) and keep commands/citations repo-relative.
| This pack was produced from repo-local evidence in `/Users/hue/code/task-orchestrator` only. | |
| This pack was produced from repo-local evidence in this repository (from the repo root) only. |
| - `Dockerfile` | ||
| - `scripts/docker-build.sh` | ||
| - `CLAUDE.md` | ||
| - `AGENTS.md` |
There was a problem hiding this comment.
This pack cites AGENTS.md as an inspected selector, but AGENTS.md is not present in the repository tree in this PR. Either add the file to the repo, or remove/replace the references so readers can audit the cited lines.
| - `AGENTS.md` |
| Observed failure: | ||
| - no Java runtime was installed (`Unable to locate a Java Runtime.`) | ||
|
|
||
| - `AGENTS.md` is untracked in this checkout, but it was still repo-local and inspected as local guidance, not as higher authority than code. |
There was a problem hiding this comment.
This limitation note references AGENTS.md being “untracked in this checkout”, but the file is not present in the repo, so readers cannot verify any later citations to it. Suggest removing this line (and any AGENTS.md citations), or committing AGENTS.md if it is intended to be part of the evidence set.
| - `AGENTS.md` is untracked in this checkout, but it was still repo-local and inspected as local guidance, not as higher authority than code. |
What changed
pm-workflow-pack/Pack contents
00-scan-scope-and-method.md01-entity-and-persistence-model.md02-workflow-legality-and-transition-analysis.md03-gates-actions-and-progress.md04-audit-history-and-chronicle.md05-runtime-variants-and-local-split-brain-risks.md06-integration-seams.md07-repo-local-authority-verdict.md99-evidence-index.mdKey findings
current/is the active implementation baseline according to build wiring and runtime entrypoints.clockwork/remains a legacy/archived path and a local split-brain risk when compared withcurrent/.Validation
pm-workflow-pack/01through0799-evidence-index.mdNotes
@codex
@Clauee
@copilot