Skip to content

OSDOCS-10730: Adding peer review feedback to upstream docs#4

Merged
jpinsonneau merged 2 commits intojpinsonneau:doc_feedbackfrom
skrthomas:main
Feb 13, 2025
Merged

OSDOCS-10730: Adding peer review feedback to upstream docs#4
jpinsonneau merged 2 commits intojpinsonneau:doc_feedbackfrom
skrthomas:main

Conversation

@skrthomas
Copy link

@skrthomas skrthomas commented Feb 12, 2025

Description

Opening a PR upstream to make sure downstream/upstream are in sync after peer review feedback incorporation.

Dependencies

Doc PR: openshift/openshift-docs#86824

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

  • Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
  • Does this PR require product documentation?
    • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
  • Does this PR require a product release notes entry?
    • If so, fill in "Release Note Text" in the JIRA.
  • Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
    • If so, make sure it is described in the JIRA ticket.
  • QE requirements (check 1 from the list):
    • Standard QE validation, with pre-merge tests unless stated otherwise.
    • Regression tests only (e.g. refactoring with no user-facing change).
    • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

@jpinsonneau jpinsonneau self-requested a review February 13, 2025 08:26
@jpinsonneau jpinsonneau changed the base branch from main to doc_feedback February 13, 2025 08:42
@jpinsonneau jpinsonneau merged commit 2b63220 into jpinsonneau:doc_feedback Feb 13, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants