Skip to content
This repository was archived by the owner on Jun 2, 2025. It is now read-only.

fix a bug in abides-market exchange agent of ABM is fixed in orderbook#15

Open
IdiosyncraticDragon wants to merge 1 commit intojpmorganchase:mainfrom
IdiosyncraticDragon:main
Open

fix a bug in abides-market exchange agent of ABM is fixed in orderbook#15
IdiosyncraticDragon wants to merge 1 commit intojpmorganchase:mainfrom
IdiosyncraticDragon:main

Conversation

@IdiosyncraticDragon
Copy link
Copy Markdown

This bug will make the kernel.run() fails if the user feeds a symbol with its value not equal to "ABM". Like this:

# it is ok for the existing code
symbol = "ABM"
# it will fail and meets KeyError: 'ABM'
symbol = "Code111"
agents.extend([ExchangeAgent(id=0,
                        name="EXCHANGE_AGENT",
                        mkt_open=mkt_open,
                        mkt_close=mkt_close,
                        symbols=[symbol],
                        book_logging=False, #
                        book_log_depth=10,
                        log_orders=True,
                        pipeline_delay=0,
                        computation_delay=0,
                        stream_history=25_000,
                             )
               ]
              )

@IdiosyncraticDragon IdiosyncraticDragon requested a review from a team as a code owner May 17, 2023 07:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant