Use "node:" prefixed imports everywhere #154
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boenrobot
force-pushed
the
runtimeCompat
branch
3 times, most recently
from
73a5006 to
947d0bc
Compare
…version to the ones that support this. CI is updated accordingly.
|
I know this is over a year later; my apologies, I must have somehow missed the notification for this. I'm not opposed to this change in principle; obviously is a breaking change. If we're going to release a major version, it probably makes sense to do other changes, like using |
RyanZim
reviewed
Aug 9, 2025
| node: [10.x, 12.x, 14.x, 16.x] | ||
| runs-on: ubuntu-latest | ||
| node: [14.18.0, 14, 16.0.0, 16] | ||
| os: [ubuntu-latest, macOS-latest, windows-latest] |
There was a problem hiding this comment.
Appveyor is windows testing; no need to duplicate it here. Is there a good reason for testing macOS separately?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And bump the minimum nodejs version to the ones that support this.
CI is updated accordingly.
Using "node:" prefixed imports enables this library to be used with runtimes other than node which have a node compatibility layer when internal dependencies are prefixed with "node:". Case in point is
workerd. The cost is raising up the minimum node version to ">=14.18.0 <15 || >=16".