Fix: Add Robust Filename Sanitization and User Docs #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit addresses two items: 1. A bugfix for filename sanitization in `process_audio.py`. The previous implementation did not correctly handle non-ASCII characters (e.g., from Whisper transcriptions), which could create filenames that are incompatible with some filesystems or tooling. The sanitization function now ensures all filenames are ASCII-safe. 2. Adds a `HOW_README.md` file with detailed instructions for setting up the environment and using the CLI tool, as requested by the user. This includes the necessary one-time manual step to make `ffmpeg` accessible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit addresses two items:
A bugfix for filename sanitization in
process_audio.py. The previous implementation did not correctly handle non-ASCII characters (e.g., from Whisper transcriptions), which could create filenames that are incompatible with some filesystems or tooling. The sanitization function now ensures all filenames are ASCII-safe.Adds a
HOW_README.mdfile with detailed instructions for setting up the environment and using the CLI tool, as requested by the user. This includes the necessary one-time manual step to makeffmpegaccessible.