Util: Drive all command invocation through Release.(raw)Exec

Author: gibson042

lib/git.js

@@ -2,12 +2,12 @@ module.exports = function( Release ) {
 
 Release.define({
 	gitLog: function( format ) {
-		var command = "git log " + Release.prevVersion + ".." + Release.newVersion + " " +
-				"--format=\"" + format + "\"",
+		var commitRange = Release.prevVersion + ".." + Release.newVersion,
+			gitLog = "git log --format=\"" + format + "\" " + commitRange,
 			result = Release.exec({
-				command: command,
+				command: gitLog,
 				silent: true
-			}, "Error getting git log, command was: " + command );
+			}, "Error getting git log, command was: " + gitLog );
 
 		result = result.split( /\r?\n/ );
 		if ( result[ result.length - 1 ] === "" ) {

lib/npm.js

@@ -1,5 +1,4 @@
-var chalk = require( "chalk" ),
-	shell = require( "shelljs" );
+var chalk = require( "chalk" );
 
 module.exports = function( Release ) {
 	Release.define({
@@ -17,7 +16,7 @@ module.exports = function( Release ) {
 		},
 
 		_getNpmOwners: function( npmPackage ) {
-			var result = shell.exec( "npm owner ls " + npmPackage, { silent: true } );
+			var result = Release.rawExec( "npm owner ls " + npmPackage, { silent: true } );
 			if ( result.code !== 0 ) {
 
 				// The npm package may not exist yet

lib/util.js

@@ -4,6 +4,10 @@ var shell = require( "shelljs" ),
 module.exports = function( Release ) {
 
 Release.define({
+	rawExec: function( command, options ) {
+		return shell.exec( command, options );
+	},
+
 	exec: function( _options, errorMessage ) {
 		var result,
 			command = _options.command || _options,
@@ -15,7 +19,7 @@ Release.define({
 
 		errorMessage = errorMessage || "Error executing command: " + command;
 
-		result = shell.exec( command, options );
+		result = Release.rawExec( command, options );
 		if ( result.code !== 0 ) {
 			Release.abort( errorMessage );
 		}