fix(browsers): get worker up and running in time to receive quick ack requests #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timmywil
force-pushed
the
quick_selenium
branch
5 times, most recently
from
e1ad506 to
992472d
Compare
…stack - short and quick selenium runs can send all xhr requests before the acknowledger can get lined up to listen for them. This was the case with jquery-mousewheel, which has been added in the tests.
timmywil
force-pushed
the
quick_selenium
branch
from
992472d to
2cfcb26
Compare
timmywil
commented
Mar 11, 2025
| // but don't wait for the page to load | ||
| // so the worker is set up in time | ||
| // for the ack request. | ||
| driver.get( url ); |
There was a problem hiding this comment.
This is the important change. It was waiting for the load event, but all of the mousewheel scripts are loaded synchronously in the head. They executed so quickly that all of the events were received before the worker was added to the list.
timmywil
commented
Mar 11, 2025
| @@ -80,10 +80,14 @@ export async function run( { | |||
| quiet: true, // Quiet server logs during test runs | |||
| testUrls, | |||
| report: async( message ) => { | |||
| const reportId = message.id; | |||
| const report = reports[ reportId ]; | |||
There was a problem hiding this comment.
This change was left over after some debugging, but it's a bit more dry so I liked it.
timmywil
commented
Mar 11, 2025
| @@ -103,12 +103,12 @@ export async function createBrowserWorker( url, browser, options, restarts = 0 ) | |||
| worker.browser = browser; | |||
| worker.restarts = restarts; | |||
| worker.options = options; | |||
| touchBrowser( browser ); | |||
There was a problem hiding this comment.
This touch was never actually applied. The following line added the worker to the list, which is needed in touchBrowser. It isn't necessary anyway and would have been immediately deleted in waitForAck().
timmywil
changed the title
timmywil
changed the title
mgol
approved these changes
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.