chore(run): remove workaround for exit-hook issue #24
+25
−40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgol
approved these changes
Nov 20, 2025
Member
mgol
left a comment
mgol
left a comment
There was a problem hiding this comment.
LGTM, just please make sure you run npm install using npm embedded with the latest minor+patch of Node.js 24 without generating lockfile changes. Something changed in the lockfile generation with regards to the peer: true fields and now that we mostly test on Node 24, it'd be good to not get into the dirty state by installing deps with npm in latest Node 24.
Member
Author
|
I noticed that in other projects as well. The |
Remove the workaround for the exit-hook issue where gracefulExit( 1 ) was not exiting with the right signal. The issue has been resolved in exit-hook v5.0.1. See sindresorhus/exit-hook#42
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the workaround for the exit-hook issue where
gracefulExit( 1 )was not exiting with the right signal. The issue has been resolved in exit-hook v5.0.1.See sindresorhus/exit-hook#42