HHH-19260 - Move supportsWithClauseInSubquery() to Dialect

Signed-off-by: Jan Schatteman <[email protected]>

Author: jrenaat

hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/AltibaseDialect.java

@@ -728,4 +728,9 @@ public boolean supportsSimpleQueryGrouping() {
 		return false;
 	}
 
+	@Override
+	public boolean supportsWithClauseInSubquery() {
+		return false;
+	}
+
 }

hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/AltibaseSqlAstTranslator.java

@@ -228,9 +228,4 @@ protected boolean supportsRowValueConstructorSyntaxInQuantifiedPredicates() {
 		return false;
 	}
 
-	@Override
-	protected boolean supportsWithClauseInSubquery() {
-		return false;
-	}
-
 }

hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/DB2LegacyDialect.java

@@ -1312,4 +1312,9 @@ public boolean supportsRowValueConstructorSyntax() {
 		return false;
 	}
 
+	@Override
+	public boolean supportsWithClauseInSubquery() {
+		return false;
+	}
+
 }

hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/DB2LegacySqlAstTranslator.java

@@ -74,11 +74,6 @@ protected boolean needsRecursiveKeywordInWithClause() {
 		return false;
 	}
 
-	@Override
-	protected boolean supportsWithClauseInSubquery() {
-		return false;
-	}
-
 	@Override
 	protected void renderTableReferenceJoins(TableGroup tableGroup, int swappedJoinIndex, boolean forceLeftJoin) {
 		// When we are in a recursive CTE, we can't render joins on DB2...

hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/H2LegacyDialect.java

@@ -1096,4 +1096,9 @@ public boolean supportsRowValueConstructorDistinctFromSyntax() {
 		return getVersion().isSameOrAfter( 1, 4, 200 );
 	}
 
+	@Override
+	public boolean supportsWithClauseInSubquery() {
+		return false;
+	}
+
 }

hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/H2LegacySqlAstTranslator.java

@@ -202,11 +202,6 @@ protected boolean shouldInlineCte(TableGroup tableGroup) {
 				&& !getCteStatement( tableGroup.getPrimaryTableReference().getTableId() ).isRecursive();
 	}
 
-	@Override
-	protected boolean supportsWithClauseInSubquery() {
-		return false;
-	}
-
 	@Override
 	protected String getArrayContainsFunction() {
 		return "array_contains";

hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/HANALegacyDialect.java

@@ -2024,4 +2024,10 @@ public boolean supportsRowValueConstructorGtLtSyntax() {
 		return false;
 	}
 
+	@Override
+	public boolean supportsWithClauseInSubquery() {
+		// HANA doesn't seem to support correlation, so we just report false here for simplicity
+		return false;
+	}
+
 }

hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/HANALegacySqlAstTranslator.java

@@ -154,12 +154,6 @@ protected boolean shouldEmulateFetchClause(QueryPart queryPart) {
 				&& !isRowsOnlyFetchClauseType( queryPart );
 	}
 
-	@Override
-	protected boolean supportsWithClauseInSubquery() {
-		// HANA doesn't seem to support correlation, so we just report false here for simplicity
-		return false;
-	}
-
 	@Override
 	protected boolean isCorrelated(CteStatement cteStatement) {
 		// Report false here, because apparently HANA does not need the "lateral" keyword to correlate a from clause subquery in a subquery

hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/HSQLLegacyDialect.java

@@ -961,4 +961,10 @@ public boolean supportsRowValueConstructorSyntax() {
 		return false;
 	}
 
+	@Override
+	public boolean supportsWithClauseInSubquery() {
+		// Doesn't support correlations in the WITH clause
+		return false;
+	}
+
 }

hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/HSQLLegacySqlAstTranslator.java

@@ -111,12 +111,6 @@ public void visitBooleanExpressionPredicate(BooleanExpressionPredicate booleanEx
 		}
 	}
 
-	@Override
-	protected boolean supportsWithClauseInSubquery() {
-		// Doesn't support correlations in the WITH clause
-		return false;
-	}
-
 	@Override
 	protected boolean supportsRecursiveClauseArrayAndRowEmulation() {
 		// Even though HSQL supports the array constructor, it's illegal to use arrays in CTEs