HHH-19260 - Move supportsNestedWithClause() to Dialect

Signed-off-by: Jan Schatteman <[email protected]>

Author: jrenaat

hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/FirebirdDialect.java

@@ -1130,4 +1130,9 @@ public boolean supportsRowValueConstructorSyntax() {
 		return false;
 	}
 
+	@Override
+	public boolean supportsNestedWithClause() {
+		return false;
+	}
+
 }

hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/FirebirdSqlAstTranslator.java

@@ -252,11 +252,6 @@ private boolean supportsOffsetFetchClause() {
 		return getDialect().getVersion().isSameOrAfter( 3 );
 	}
 
-	@Override
-	protected boolean supportsNestedWithClause() {
-		return false;
-	}
-
 	@Override
 	public void visitSelfRenderingPredicate(SelfRenderingPredicate selfRenderingPredicate) {
 		// see comments in visitParameter

hibernate-core/src/main/java/org/hibernate/dialect/Dialect.java

@@ -6013,4 +6013,11 @@ public boolean supportsWithClauseInSubquery() {
 		return supportsWithClause();
 	}
 
+	/**
+	 * Whether the SQL with clause is supported within a CTE.
+	 */
+	public boolean supportsNestedWithClause() {
+		return supportsWithClauseInSubquery();
+	}
+
 }

hibernate-core/src/main/java/org/hibernate/sql/ast/spi/AbstractSqlAstTranslator.java

@@ -2145,7 +2145,7 @@ public void visitCteContainer(CteContainer cteContainer) {
 			pushToTopLevel = false;
 		}
 		else {
-			pushToTopLevel = !supportsNestedWithClause()
+			pushToTopLevel = !dialect.supportsNestedWithClause()
 					|| !dialect.supportsWithClauseInSubquery() && isInSubquery();
 		}
 		final boolean inNestedWithClause = clauseStack.findCurrentFirst( AbstractSqlAstTranslator::matchWithClause ) != null;
@@ -2414,13 +2414,6 @@ protected void visitCteDefinition(CteStatement cte) {
 		limit = oldLimit;
 	}
 
-	/**
-	 * Whether the SQL with clause is supported within a CTE.
-	 */
-	protected boolean supportsNestedWithClause() {
-		return dialect.supportsWithClauseInSubquery();
-	}
-
 	/**
 	 * Whether CTEs should be inlined rather than rendered as CTEs.
 	 */