-
Notifications
You must be signed in to change notification settings - Fork 55
Allow to create workspace #701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…that contains jrl-cmakemodule
…t_finalize must be run automatically
for more information, see https://pre-commit.ci
|
Thanks for this work ! |
|
I will push similar PR on:
I will also create a new repository called simple-robotics/workspace that will store the root CMakelists.txt and probably some scripts to populate the workspace. |
|
I keep this PR as a draft until I'm sure all modified project still build in standalone mode in the CI. |
jcarpent
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Impressive work @jorisv
|
@nim65s If you want to test it, I have uploaded the workspace repository. If the README.md is hard to understand or you encounter some issues please add some comment in this PR |
jcarpent
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR aims to allow project using jrl-cmakemodules to be used under the same root CMakeLists.txt (workspace).
PROJECT_PACKAGES_IN_WORKSPACEthat should avoid running find_package inADD_PROJECT_DEPENDENCYandADD_PROJECT_PRIVATE_DEPENDENCYon project already in the workspaceADD_PROJECT_PRIVATE_DEPENDENCYthat check forPROJECT_PACKAGES_IN_WORKSPACEbefore calling find_packagePROJECT_PYTHON_PACKAGES_IN_WORKSPACEto include Python modules from workspace inPYTHONPATHPROJECT_SOURCE_DIRandPROJECT_BINARY_DIRinstead ofCMAKE_SOURCE_DIRandCMAKE_BINARY_DIRsince thedistanddoctarget is working with multiple project butdistcheckis not working. Sincedistcheckdo some very heroic thing with the CMakeCache.txt, I don't think we can make it work for multiple project.