Open
Conversation
Incremental PR from `develop` to `main`.
Trying to fix the CI compile issue with for the SPI.h include on SimpleFOC.
This reverts commit a83a43c.
This reverts commit 819c123.
…//github.com/Arribe/OpenHornet-Software into feature-new_sketch-4A9A1-THROTTLE_CONTROLLER
This reverts commit cb70eba.
…mpleFOC" This reverts commit b3bd712.
CI still doesn't work.
jrsteensen
force-pushed
the
pr-101-restore
branch
from
9fc5731 to
9d24776
Compare
jrsteensen
added
Type: Enhancement
16 tasks
updated git modules to remove reference to simple foc, and updated throttle code accordingly for the use of OH MT6836 library, with note it's derived from simple foc (library includes the note as well, just making sure it's doubly obvious).
testing only making the throttle
cleaned up include calls.
Added $(LIBRARY_DIR)/FastLED/examples to the EXCLUDE_DIRS variable in esp.mk to prevent compilation and linking of example files from the FastLED library.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.
Cloning #101 since i broke Arribes. #101 should be considered the governing PR.