chore: Update to support Rails 8.0 … #1174
Merged
+36
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Bump version to 80.0 for Rails 8.0.x support │ - Update activerecord dependency to ~> 8.0.0 │ - Update README to show master branch targets Rails 8.0.x │ - Add 72-stable branch for Rails 7.2.x support │ - Require JRuby 10.0.0 minimum for Rails 8 │ - Fix deprecated File.exists? to File.exist?
Member
|
@seuros thanks for trying to get this setup. The PR nearly worked but it is still requiring Java 1.8 (which was what JRuby 9.4 and lower required) and JRuby 10 requires Java 21 or higher. |
Contributor
Author
|
Ok, will fix it in few. |
Contributor
Author
|
Just noticed the commit message, has the secret vim exit handshake. :D |
Member
|
@seuros Thanks. Things are not looking horrible on the test front for 8. mysql is missing something really important but the other two seem like they may take less work to get back to green on local tests. I am not sure if the recent zeitworks fixes to JRuby have landed but that could help some results too (older Rails test runs had some missing constant errors which are probably from that). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PS: still getting familiar with this code base.