adjust gem post install hook to allow updating the default gem #78
Conversation
see jruby/jruby#7262 rubygems/defaults/jruby.rb needs to _not_ require a file from jar-dependencies when it first runs, otherwise bundler can't load a version of jar-dependencies that's installed later. this commit is intended to have jruby.rb register the post-install hook itself, and therefore defer loading jar-dependencies until it's actually needed. jruby needs an update for its defaults to match the new jar_install_post_install_hook.rb. in the meantime, this commit is compatible with the current defaults or an updated one.
fixes jruby#7262, but requires jruby/jar-dependencies#78 to be merged and released first.
|
see also jruby/jruby#7263 |
|
@mkristian We still need to sit down and figure out how to share the load of maintaining these libraries. Perhaps you have some time to chat soon? |
fixes jruby#7262, but requires jruby/jar-dependencies#78 to be merged and released first.
|
speaking of maintaining... would anyone be opposed to me applying rubocop to this gem? I've got a couple features I want to add, but I'll admit I'm lazy and format my code terrible, and let rubocop do it. |
|
Please do so .... no objections from my side
|
|
|
@mkristian Has this gotten into a release yet? If not, we can go ahead and push it, assuming there's nothing complicated about doing so (instructions and permissions needed, of course). |
|
@headius I did not release it yet. so either or after @ccutrer added the 'default' tasks to the Rakefile There are now github actions: https://github.com/mkristian/jar-dependencies/actions There are some maven integration tests but they seems all very flaky and over time I comment them out more and more. They are for sure tricky to maintain from maven point of view. And launching maven from JRuby which kind of forks a new maven process with jruby seems kind of too much. |
|
@mkristian Great! I will get this released today. |
|
jar-dependencies 0.4.2 has been released! |
|
Revisiting this. We need an answer. |
3 participants
see jruby/jruby#7262
rubygems/defaults/jruby.rb needs to not require a file from
jar-dependencies when it first runs, otherwise bundler can't
load a version of jar-dependencies that's installed later.
this commit is intended to have jruby.rb register the
post-install hook itself, and therefore defer loading
jar-dependencies until it's actually needed. jruby needs
an update for its defaults to match the new
jar_install_post_install_hook.rb. in the meantime, this
commit is compatible with the current defaults or an
updated one.