Skip to content

Commit dc9fd1e

Browse files
committed
Merge branch 'master' into jakarta-update
2 parents 09e609e + c3b9709 commit dc9fd1e

File tree

8 files changed

+44
-15
lines changed

8 files changed

+44
-15
lines changed

.github/workflows/maven.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -32,10 +32,10 @@ jobs:
3232
fail-fast: false
3333

3434
steps:
35-
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
35+
- uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
3636

3737
- name: Set up JDK
38-
uses: actions/setup-java@c5195efecf7bdfc987ee8bae7a71cb8b11521c00 # v4.7.1
38+
uses: actions/setup-java@dded0888837ed1f317902acf8a20df0ad188d165 # v5.0.0
3939
with:
4040
java-version: ${{ matrix.java_version }}
4141
distribution: 'temurin'
@@ -83,10 +83,10 @@ jobs:
8383
JRUBY_VERSION: ${{ matrix.jruby_version }}
8484

8585
steps:
86-
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
86+
- uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
8787

8888
- name: Set up JDK
89-
uses: actions/setup-java@c5195efecf7bdfc987ee8bae7a71cb8b11521c00 # v4.7.1
89+
uses: actions/setup-java@dded0888837ed1f317902acf8a20df0ad188d165 # v5.0.0
9090
with:
9191
java-version: ${{ matrix.java_version }}
9292
distribution: 'temurin'

History.md

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,11 @@
2323
- Change context listener to throw, in case of an exception during initialization, by default
2424
- Change rails context listener to assume a thread-safe application by default
2525

26-
## 1.2.5 (UNRELEASED)
26+
## 1.2.6 (UNRELEASED)
27+
28+
- Add missing block-only signature for debug logging
29+
30+
## 1.2.5
2731

2832
- Fix use of jruby-rack under Java 8 (#324)
2933
- Fix deprecated usages of JRuby runtime

examples/camping/Gemfile.lock

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
GIT
22
remote: https://github.com/jruby/warbler.git
3-
revision: f10ed60aefe3bf498917bfd18de780fb7d240f65
3+
revision: 523237b6d931efcd6f13a79692f6aa46ad997443
44
branch: master
55
specs:
66
warbler (2.0.5)
@@ -9,7 +9,7 @@ GIT
99
ostruct (= 0.6.2)
1010
rake (>= 13.0.3)
1111
rexml (~> 3.0)
12-
rubyzip (>= 1.0.0)
12+
rubyzip (>= 3.0.0)
1313

1414
GEM
1515
remote: https://rubygems.org/
@@ -19,7 +19,7 @@ GEM
1919
mab (>= 0.0.3)
2020
rack (>= 1.0)
2121
jruby-jars (9.4.14.0)
22-
jruby-rack (1.2.3)
22+
jruby-rack (1.2.5)
2323
mab (0.0.3)
2424
markaby (0.9.4)
2525
builder
@@ -29,8 +29,8 @@ GEM
2929
rack (< 3)
3030
webrick
3131
rake (13.3.0)
32-
rexml (3.4.1)
33-
rubyzip (2.4.1)
32+
rexml (3.4.3)
33+
rubyzip (3.1.0)
3434
webrick (1.9.1)
3535

3636
PLATFORMS

examples/rails7/Gemfile.lock

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -74,11 +74,11 @@ GEM
7474
tzinfo (~> 2.0, >= 2.0.5)
7575
base64 (0.3.0)
7676
benchmark (0.4.1)
77-
bigdecimal (3.2.2-java)
77+
bigdecimal (3.2.3-java)
7878
builder (3.3.0)
7979
cgi (0.5.0-java)
8080
concurrent-ruby (1.3.5)
81-
connection_pool (2.5.3)
81+
connection_pool (2.5.4)
8282
crass (1.0.6)
8383
date (3.4.1-java)
8484
drb (2.2.3)
@@ -108,7 +108,7 @@ GEM
108108
marcel (1.0.4)
109109
mini_mime (1.1.5)
110110
minitest (5.25.5)
111-
net-imap (0.5.9)
111+
net-imap (0.5.10)
112112
date
113113
net-protocol
114114
net-pop (0.1.2)

examples/sinatra/Gemfile.lock

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ GEM
33
specs:
44
base64 (0.3.0)
55
jruby-jars (9.4.14.0)
6-
jruby-rack (1.2.4)
6+
jruby-rack (1.2.5)
77
mustermann (3.0.4)
88
ruby2_keywords (~> 0.0.1)
99
rack (2.2.17)

pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -283,7 +283,7 @@
283283
<plugin>
284284
<groupId>org.codehaus.mojo</groupId>
285285
<artifactId>versions-maven-plugin</artifactId>
286-
<version>2.18.0</version>
286+
<version>2.19.0</version>
287287
<configuration>
288288
<ignoredVersions>.*-(alpha|beta|M)[-0-9]+</ignoredVersions>
289289
</configuration>

src/main/java/org/jruby/rack/ext/Logger.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -242,6 +242,11 @@ public IRubyObject debug(final ThreadContext context,
242242
return context.runtime.newBoolean( add(DEBUG, context, msg, block) );
243243
}
244244

245+
@JRubyMethod(name = "debug")
246+
public IRubyObject debug(final ThreadContext context, final Block block) {
247+
return debug(context, context.nil, block);
248+
}
249+
245250
//
246251
// :call-seq:
247252
// info(message)

src/spec/ruby/jruby/rack/logger_spec.rb

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -86,6 +86,26 @@
8686
expect(logger.warn?).to be true
8787
end
8888

89+
[:debug, :info, :warn, :error, :fatal].each do |level|
90+
it "logs at #{level} level" do
91+
logger.public_send(level, 'message')
92+
expect(real_logger.logged_content).to eql "#{level.to_s.upcase}: message\n"
93+
94+
real_logger.reset
95+
logger.public_send(level, 'message') { 'ignored' }
96+
expect(real_logger.logged_content).to eql "#{level.to_s.upcase}: message\n"
97+
98+
real_logger.reset
99+
logger.public_send(level, nil) { 'message' }
100+
expect(real_logger.logged_content).to eql "#{level.to_s.upcase}: message\n"
101+
102+
103+
real_logger.reset
104+
logger.public_send(level) { 'message' }
105+
expect(real_logger.logged_content).to eql "#{level.to_s.upcase}: message\n"
106+
end
107+
end
108+
89109
it "disables real logger's formatting when formatter is set" do
90110
real_logger.formatting = true
91111
expect(real_logger.formatting?).to be true

0 commit comments

Comments
 (0)