[build] Re-introduce Java 8 compatibility for 1.3.x #315
+55
−36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chadlwilson
force-pushed
the
back-to-java-8
branch
from
768a3a7 to
629481a
Compare
chadlwilson
force-pushed
the
back-to-java-8
branch
from
629481a to
c89f44c
Compare
|
If you're OK with re-introducing this compatibility, despite what we noted in #285, I'll merge :-/ |
|
think everyone upgrading to >= 1.3 would be at least on 11 but I do not really have anything against supporting older... |
|
I'd hope so too, but I guess it's no big deal. Doesn't make the code that much cleaner to target Java 11. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-introduces Java 8 compatibility as requested at #234 (comment) and #266 (comment)
This partially undoes #285 and #286 (and some minor subsequent code style refactorings).