Remove 1.0/1.1-era API deprecations; Rack < 2.2 code JRuby < 9.3 code #318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chadlwilson
force-pushed
the
tidy-deprecations
branch
from
d8dd342 to
f31cdef
Compare
chadlwilson
changed the title
chadlwilson
changed the title
chadlwilson
force-pushed
the
tidy-deprecations
branch
3 times, most recently
from
4d092aa to
f21c6c9
Compare
chadlwilson
changed the title
chadlwilson
force-pushed
the
tidy-deprecations
branch
3 times, most recently
from
a9f0fc2 to
1a472f1
Compare
Contributor
Author
|
@kares do you have any thoughts about this collection of small clean-ups (in sequence of separate commits)? The main thing left over I am not sure what to do with is the |
chadlwilson
force-pushed
the
tidy-deprecations
branch
from
1a472f1 to
a496a8e
Compare
- Removes logic for Ruby < 1.9 - Removes deprecated accept_html alias - Remove backward compatibility support for Rack versions < 2.2
…JRuby::Rack::FileSystemLayout
…ng ago by `jruby.runtime.env` and optional `jruby.runtime.env.rubyopt`
…fine rack.version This is more forward compatible with Rack 3.x.
It's confusing here to test with a non-compatible version
catWithCodeRange will not work with JRuby < 9.4.7.0 (Apr 2024), but as this patch release is 18 months old, it's reasonable to expect patching.
chadlwilson
force-pushed
the
tidy-deprecations
branch
from
a496a8e to
f5e390c
Compare
Contributor
Author
|
These are mainly not contentious since they were deprecated long ago, so will merge this in so I can avoid maintaining too many branches as I have a few things in flight, including a Rack 3.x experiment. I'll revert anything of concern or deal with devlog/servletlog later if necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More cleanup for 1.3 of things we didn't end up removing for 1.2.
See the
History.mdchanges for more detail on the property/API changes.https://github.com/jruby/jruby-rack/pull/318/files#diff-abfa5988643af1b8b2600aac13b273922dbb3372e021bf1d7caadfe7473c9561L9-R16
The subset of these which are pure removal of unnecessary code (not removing public APIs/props) I intend to backport/cherry-pick to
1.2-stablesince they are equally applicable there. (basically the technical changes not needing documenting in the changelog/history)