Fix JSP forward/include under Rails 7 #371
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This logic has been moved to re-usable helpers a long time back, which Rails and other frameworks rely upon. Patching modules already included doesn't appear to work on Ruby 2.6/JRuby 9.3 so add a fallback to patch the classes known to include. Don't know a better way; but this logic will be dropped on jruby-rack 1.3.
chadlwilson
force-pushed
the
fix-rails-jsp-handling
branch
from
a6f0226 to
d9ce73b
Compare
kares
reviewed
Nov 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
forward_toandincludesupport broken on Rails 5+ #370Will also address other frameworks which re-use Rack capabilities and are "Rack compatible" rather than directly using Rack types.