-
Notifications
You must be signed in to change notification settings - Fork 35
GetIntrinsic: remove from PlainDate, add monkeypatching test #105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jens-ox
wants to merge
10
commits into
js-temporal:main
Choose a base branch
from
jens-ox:remove-get-intrinsic
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
71239c8
remove getIntrinsic from plaindate, add monkeypatching test
jens-ox f114d6c
Merge branch 'main' of github.com:jens-ox/temporal-polyfill into remo…
jens-ox 3dd5bef
wip
jens-ox f2684b5
merging with changes on main
jens-ox 4c126eb
fix merge error, update test262
jens-ox fe81b40
Merge branch 'main' of github.com:jens-ox/temporal-polyfill into remo…
jens-ox 34c3049
update tests
jens-ox c4753f4
Merge branch 'main' of github.com:jens-ox/temporal-polyfill into remo…
jens-ox 516b4d3
remove unnecessary defaults from package.json
jens-ox 1c4fc3b
remove unnecessary defaults from tsconfig.json
jens-ox File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,3 +5,4 @@ tsc-out/ | |
.vscode/* | ||
!.vscode/launch.json | ||
*.tgz | ||
.DS_Store |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
#! /usr/bin/env -S node --experimental-modules | ||
|
||
import Demitasse from '@pipobscure/demitasse'; | ||
const { describe, it, report } = Demitasse; | ||
|
||
import Pretty from '@pipobscure/demitasse-pretty'; | ||
const { reporter } = Pretty; | ||
|
||
import { strict as assert } from 'assert'; | ||
const { equal } = assert; | ||
|
||
import * as Temporal from '@js-temporal/polyfill'; | ||
const { PlainDate } = Temporal; | ||
|
||
describe('Monkeypatch', () => { | ||
describe('PlainDate', () => { | ||
it("Monkeypatching Duration doesn't affect PlainDate", () => { | ||
Temporal.Duration.prototype.constructor = null; | ||
const date = PlainDate.from('2021-12-09'); | ||
equal(`${date.until('2021-12-10')}`, 'P1D'); | ||
}); | ||
}); | ||
}); | ||
|
||
import { normalize } from 'path'; | ||
if (normalize(import.meta.url.slice(8)) === normalize(process.argv[1])) { | ||
report(reporter).then((failed) => process.exit(failed ? 1 : 0)); | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably we also want to check
Temporal.Duration = null
anddelete Temporal.Duration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As the tests are
.mjs
, imports will be read-only, so JS won't let us do those two things (although monkeypatching the prototype seems to be valid).