Skip to content

Update Documentation.md #372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update Documentation.md #372

wants to merge 2 commits into from

Conversation

RahulDey12
Copy link

pID is not the id required to remove the Item its row ID.

jsgantt-improved/src/task.ts

Line 528 in 4d80456

if (this.vTaskList[i].getID() == pID) this.vTaskList[i].setToDelete(true);

@DevAshishY
Copy link

ok

1 similar comment
@DevAshishY
Copy link

ok

@mariohmol
Copy link
Collaborator

good catch..
maybe we can add both.. by ID or Row?

@RahulDey12
Copy link
Author

@mariohmol That will also work. Just to clarify the confutions

@mariohmol
Copy link
Collaborator

I'm sorry, I 'm confused now.

The code does check by pID, not by row number...what Am I missing here?

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RahulDey12 @DevAshishY @mariohmol