Code improving proposals #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code of the repository is legible (CSS and HTML). It is structured with the coresponding sections including header, navigation, main and footer. Aditionally, the design of the webpage is esthetic, organized and colors have a good contrast between them. However some of the images in he carrousel get distorted. The navigation is consistent, and it is easy to navigate throught the different sections of the page. Morover the CSS rules are overally named consistently with their objectives.
With this pull request I suggest some changes for improving the coding quality but overally it was very well coded.
Here is a picture of the validator:
