Merged
Conversation
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
# Conflicts: # CHANGELOG.md # Cargo.toml # README.md # benchmarks/Cargo.toml # crates/bacnet-transport/src/bip.rs # examples/kotlin/BipClientServer.kt # examples/kotlin/README.md # java/gradle.properties
Contributor
There was a problem hiding this comment.
Pull request overview
This PR bumps the workspace to 0.7.0 and introduces the new bacnet-btl crate, implementing a BTL Test Plan 26.1 test harness with CLI/shell tooling, reporting, and a large set of sectioned test registrations.
Changes:
- Added the
bacnet-btlcrate (engine, registry/selector/runner, IUT capabilities, reporting, CLI/shell, self-test scaffolding). - Added many new BTL test modules across Sections 3–4 (Objects + Data Sharing) and wired them into the global test registry.
- Updated version references and documentation (workspace version bump, README, changelog entries, benchmarks version).
Reviewed changes
Copilot reviewed 80 out of 227 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| crates/bacnet-btl/src/tests/s04_data_sharing/rp_b.rs | Adds DS-RP-B (ReadProperty server execution) test registrations and implementations. |
| crates/bacnet-btl/src/tests/s04_data_sharing/read_range.rs | Adds ReadRange (RR-A/RR-B) test registrations and placeholder implementations. |
| crates/bacnet-btl/src/tests/s04_data_sharing/mod.rs | Introduces Section 4 module wiring and registration ordering. |
| crates/bacnet-btl/src/tests/s04_data_sharing/domain_specific.rs | Adds domain-specific data sharing test registrations (life safety/access control/lighting/elevator). |
| crates/bacnet-btl/src/tests/s04_data_sharing/cov_unsub.rs | Adds COV Unsubscribed tests and registrations. |
| crates/bacnet-btl/src/tests/s04_data_sharing/cov_property.rs | Adds COV Property tests and registrations (includes parameterized ID/name generation). |
| crates/bacnet-btl/src/tests/s04_data_sharing/cov_multiple.rs | Adds COV Multiple tests and registrations (includes parameterized ID/name generation). |
| crates/bacnet-btl/src/tests/s04_data_sharing/cov_a.rs | Adds DS-COV-A test registrations and basic subscription helpers. |
| crates/bacnet-btl/src/tests/s03_objects/trend_log.rs | Adds Trend Log object tests (REI coverage). |
| crates/bacnet-btl/src/tests/s03_objects/structured_view.rs | Adds Structured View object tests. |
| crates/bacnet-btl/src/tests/s03_objects/schedule.rs | Adds Schedule object tests. |
| crates/bacnet-btl/src/tests/s03_objects/program.rs | Adds Program object tests (Program_Change + REI). |
| crates/bacnet-btl/src/tests/s03_objects/notification_forwarder.rs | Adds NotificationForwarder object test registrations. |
| crates/bacnet-btl/src/tests/s03_objects/notification_class.rs | Adds NotificationClass object tests. |
| crates/bacnet-btl/src/tests/s03_objects/network_port.rs | Adds NetworkPort object tests. |
| crates/bacnet-btl/src/tests/s03_objects/multistate_value.rs | Adds Multi-State Value object tests. |
| crates/bacnet-btl/src/tests/s03_objects/multistate_output.rs | Adds Multi-State Output object tests. |
| crates/bacnet-btl/src/tests/s03_objects/multistate_input.rs | Adds Multi-State Input object tests. |
| crates/bacnet-btl/src/tests/s03_objects/mod.rs | Introduces Section 3 module wiring and registration ordering. |
| crates/bacnet-btl/src/tests/s03_objects/loop_obj.rs | Adds Loop object tests. |
| crates/bacnet-btl/src/tests/s03_objects/load_control.rs | Adds LoadControl object tests. |
| crates/bacnet-btl/src/tests/s03_objects/life_safety.rs | Adds LifeSafetyPoint/Zone object tests. |
| crates/bacnet-btl/src/tests/s03_objects/group.rs | Adds Group object tests. |
| crates/bacnet-btl/src/tests/s03_objects/file.rs | Adds File object tests. |
| crates/bacnet-btl/src/tests/s03_objects/event_log.rs | Adds EventLog object tests. |
| crates/bacnet-btl/src/tests/s03_objects/event_enrollment.rs | Adds EventEnrollment + AlertEnrollment object tests. |
| crates/bacnet-btl/src/tests/s03_objects/elevator.rs | Adds Elevator/Lift/Escalator object tests. |
| crates/bacnet-btl/src/tests/s03_objects/device.rs | Adds Device object tests. |
| crates/bacnet-btl/src/tests/s03_objects/command.rs | Adds Command object tests. |
| crates/bacnet-btl/src/tests/s03_objects/calendar.rs | Adds Calendar object tests. |
| crates/bacnet-btl/src/tests/s03_objects/binary_input.rs | Adds Binary Input object tests. |
| crates/bacnet-btl/src/tests/s03_objects/averaging.rs | Adds Averaging object tests. |
| crates/bacnet-btl/src/tests/s03_objects/audit.rs | Adds AuditReporter/AuditLog object tests. |
| crates/bacnet-btl/src/tests/s03_objects/analog_value.rs | Adds Analog Value object tests (with an unused local). |
| crates/bacnet-btl/src/tests/s03_objects/analog_output.rs | Adds Analog Output object tests. |
| crates/bacnet-btl/src/tests/s03_objects/analog_input.rs | Adds Analog Input object tests. |
| crates/bacnet-btl/src/tests/s03_objects/accumulator.rs | Adds Accumulator/PulseConverter object tests. |
| crates/bacnet-btl/src/tests/s03_objects/access_door.rs | Adds AccessDoor object tests. |
| crates/bacnet-btl/src/tests/s02_basic/mod.rs | Adds Section 2 module wrapper and registration entrypoint. |
| crates/bacnet-btl/src/tests/mod.rs | Adds top-level test module wiring and register_all. |
| crates/bacnet-btl/src/shell.rs | Adds interactive REPL for listing/running tests. |
| crates/bacnet-btl/src/self_test/mod.rs | Adds self-test module and DB access handle wrapper. |
| crates/bacnet-btl/src/report/terminal.rs | Adds terminal reporter for test runs and step diagnostics. |
| crates/bacnet-btl/src/report/model.rs | Adds JSON-serializable result model (run/suite/test/steps/status). |
| crates/bacnet-btl/src/report/mod.rs | Adds report module wiring (json/model/terminal). |
| crates/bacnet-btl/src/report/json.rs | Adds JSON serialization + file output helpers. |
| crates/bacnet-btl/src/lib.rs | Adds crate root module exports for engine/iut/report/self_test/tests. |
| crates/bacnet-btl/src/iut/mod.rs | Adds IUT module wiring. |
| crates/bacnet-btl/src/iut/capabilities.rs | Adds IUT capability model used for selection/conditionality. |
| crates/bacnet-btl/src/engine/selector.rs | Adds conditionality + user-filter based test selection. |
| crates/bacnet-btl/src/engine/runner.rs | Adds test runner that executes selected tests and builds TestRun. |
| crates/bacnet-btl/src/engine/registry.rs | Adds registry types (Section/Capability/Conditionality/TestDef/TestRegistry). |
| crates/bacnet-btl/src/engine/mod.rs | Adds engine module wiring. |
| crates/bacnet-btl/src/engine/make.rs | Adds MAKE action model (direct DB/write-or-prompt/manual). |
| crates/bacnet-btl/src/cli.rs | Adds clap CLI definitions for list/run/self-test/shell/serve. |
| crates/bacnet-btl/Cargo.toml | Adds new crate manifest and feature flags for capture/SC TLS/etc. |
| benchmarks/Cargo.toml | Bumps benchmarks crate version to 0.7.0. |
| README.md | Updates public-facing docs for 0.7.0 and documents the new BTL harness. |
| Cargo.toml | Adds bacnet-btl to the workspace and bumps workspace dependencies to 0.7.0. |
| CHANGELOG.md | Adds detailed 0.7.0 changelog entry covering the new harness + stack fixes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
0.7.0 - See changelog for updates.