fix: use configured BIP port for gateway client transport#8
Merged
jscott3201 merged 1 commit intojscott3201:devfrom Mar 24, 2026
Merged
fix: use configured BIP port for gateway client transport#8jscott3201 merged 1 commit intojscott3201:devfrom
jscott3201 merged 1 commit intojscott3201:devfrom
Conversation
The client transport was hardcoded to port 0, causing the OS to assign a random ephemeral port for outgoing BACnet requests. This breaks device communication when devices respond to the standard BACnet port (47808) and the client is listening on a different random port. Use `bip.port` from the gateway config, matching the server transport which already used the configured port correctly. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Owner
|
Nice catch! I'll let this run on checks and get that fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
0inbuilder.rs:134, causing the OS to assign a random ephemeral port for outgoing BACnet/IP requestsbip.portfrom the gateway configbip.portto the client transport as wellThe bug
Impact
Outgoing BACnet requests originated from a random port instead of the configured BACnet/IP port (typically 47808). Devices responding to the standard port would not reach the client, breaking request/response communication.
🤖 Generated with Claude Code