Add RFC3489 RESPONSE-ADDRESS support with security opt-in#66
Open
KP000007 wants to merge 2 commits intojselbie:masterfrom
Open
Add RFC3489 RESPONSE-ADDRESS support with security opt-in#66KP000007 wants to merge 2 commits intojselbie:masterfrom
KP000007 wants to merge 2 commits intojselbie:masterfrom
Conversation
Implement support for the RFC3489 RESPONSE-ADDRESS attribute used in Binding Lifetime Discovery. This feature is disabled by default and requires the --allow-response-address-unsafe flag due to DoS amplification risks. - Add GetResponseAddress() method to CStunMessageReader - Add --allow-response-address-unsafe command-line option - Pass flag through server config and TransportAddressSet - Update messagehandler to honor RESPONSE-ADDRESS when enabled - Document security implications in stunserver.md Signed-off-by: Panagiotis Katsikogiannis <panagiotis.katsikogiannis@mitel.com>
Updated stunserver.txtcode from stunserver.md to include the new --allow-response-address-unsafe flag in the help output. Signed-off-by: Panagiotis Katsikogiannis <panagiotis.katsikogiannis@mitel.com>
Owner
|
Thank you. I'll take a look within the next couple of days. |
Author
|
Is there any update on this one? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement support for the RFC3489 RESPONSE-ADDRESS attribute used in Binding Lifetime Discovery. This feature is disabled by default and requires the --allow-response-address-unsafe flag due to DoS amplification risks.