Skip to content

Conversation

@GroophyLifefor
Copy link
Contributor

Related to #413
Backlogged in #414

@GroophyLifefor
Copy link
Contributor Author

Hey @UlisesGascon , can you review when available?

Copy link
Member

@jonchurch jonchurch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as #428 (review)

This will not survive running the build step

@GroophyLifefor
Copy link
Contributor Author

I hope I did it right.

Copy link
Member

@jonchurch jonchurch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't looked into this issue enough yet to have an opinion about including this change

But what I will say is that a LOT of file formats are technically zip files, and yet we dont list them all here.

That's for discusson on that issue though. For now I will mark request changes as a block

@GroophyLifefor
Copy link
Contributor Author

I haven't looked into this issue enough yet to have an opinion about including this change

But what I will say is that a LOT of file formats are technically zip files, and yet we dont list them all here.

That's for discusson on that issue though. For now I will mark request changes as a block

You right and if code not has a problem, it's okay in my side. I just opened this PR because I saw issue in Backlog for Release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants