Skip to content
This repository was archived by the owner on Aug 21, 2020. It is now read-only.

Conversation

JadMokdad
Copy link

@JadMokdad JadMokdad commented Jul 2, 2018

Fixes issue #261

@JadMokdad JadMokdad changed the title fix: Surrounded recorder.start() with try/catch to handle runtime exc… fix: Surrounded recorder.start() throwing unhandled exception Jul 2, 2018
@JadMokdad JadMokdad closed this Jul 2, 2018
@JadMokdad JadMokdad reopened this Jul 2, 2018
@JadMokdad JadMokdad changed the title fix: Surrounded recorder.start() throwing unhandled exception fix: Catched unhandled exceptions on recorder.start() Jul 2, 2018
@JadMokdad JadMokdad changed the title fix: Catched unhandled exceptions on recorder.start() fix: Catched unhandled exception on recorder.start() Jul 2, 2018
@jsierles
Copy link
Owner

Thans for the patch! I see here you're catching all exceptions. Can we catch the specific exception thrown here?

@JadMokdad
Copy link
Author

Please find below the stack trace dump

07-29 12:24:06.839 19360 19413 E AndroidRuntime: FATAL EXCEPTION: mqt_native_modules
07-29 12:24:06.839 19360 19413 E AndroidRuntime: Process: com.example, PID: 19360
07-29 12:24:06.839 19360 19413 E AndroidRuntime: java.lang.NullPointerException: Attempt to invoke virtual method 'int java.lang.String.length()' on a null object reference
07-29 12:24:06.839 19360 19413 E AndroidRuntime:        at java.lang.AbstractStringBuilder.<init>(AbstractStringBuilder.java:87)
07-29 12:24:06.839 19360 19413 E AndroidRuntime:        at java.lang.StringBuilder.<init>(StringBuilder.java:95)
07-29 12:24:06.839 19360 19413 E AndroidRuntime:        at com.facebook.react.devsupport.DevSupportManagerImpl$JSExceptionLogger.log(DevSupportManagerImpl.java:301)
07-29 12:24:06.839 19360 19413 E AndroidRuntime:        at com.facebook.react.devsupport.DevSupportManagerImpl.handleException(DevSupportManagerImpl.java:285)
07-29 12:24:06.839 19360 19413 E AndroidRuntime:        at com.facebook.react.bridge.CatalystInstanceImpl.onNativeException(CatalystInstanceImpl.java:511)
07-29 12:24:06.839 19360 19413 E AndroidRuntime:        at com.facebook.react.bridge.CatalystInstanceImpl.access$900(CatalystInstanceImpl.java:39)
07-29 12:24:06.839 19360 19413 E AndroidRuntime:        at com.facebook.react.bridge.CatalystInstanceImpl$NativeExceptionHandler.handleException(CatalystInstanceImpl.java:527)
07-29 12:24:06.839 19360 19413 E AndroidRuntime:        at com.facebook.react.bridge.queue.MessageQueueThreadHandler.dispatchMessage(MessageQueueThreadHandler.java:31)
07-29 12:24:06.839 19360 19413 E AndroidRuntime:        at android.os.Looper.loop(Looper.java:148)
07-29 12:24:06.839 19360 19413 E AndroidRuntime:        at com.facebook.react.bridge.queue.MessageQueueThreadImpl$3.run(MessageQueueThreadImpl.java:192)
07-29 12:24:06.839 19360 19413 E AndroidRuntime:        at java.lang.Thread.run(Thread.java:818)
07-29 12:24:06.839   719  1736 W ActivityManager:   Force finishing activity com.example/.MainActivity
07-29 12:24:06.849   719 19540 W DropBoxManagerService: Dropping: data_app_crash (1233 > 0 bytes)
07-29 12:24:06.869   719 19542 E android.os.Debug: ro.product_ship = true
07-29 12:24:06.869   719 19542 E android.os.Debug: ro.debug_level = 0x4f4c
07-29 12:24:06.869   719 19542 E android.os.Debug: sys.mobilecare.preload = false
07-29 12:24:06.869 16870 16870 W ContextImpl: Calling a method in the system process without a qualified user: android.app.ContextImpl.startService:1320 android.content.ContextWrapper.startService:606 android.content.ContextWrapper.startService:606 com.samsung.android.sm.common.SmartManagerReceiver.b:281 com.samsung.android.sm.common.SmartManagerReceiver.onReceive:117
07-29 12:24:07.569   332   680 W AudioALSAHardware: setParameters(), still have param.size() = 1, remain param = "HOTWORD_STOPINPUT="
07-29 12:24:07.569   332   819 E APM::AudioPolicyManager: startInput(277) failed: other input 268 already started
07-29 12:24:07.569  1269  1772 E AudioRecord: start() status -38
07-29 12:24:07.569  1269  1772 E AudioProvider: recording stopped, not in RECORDSTATE_RECORDING state

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants