Skip to content

[voicevox] install python-is-python3 for text2wave. catkin_install_python cannot install text2wave correctly#536

Closed
mqcmd196 wants to merge 1 commit intojsk-ros-pkg:masterfrom
mqcmd196:fix-voicevox-shebang
Closed

[voicevox] install python-is-python3 for text2wave. catkin_install_python cannot install text2wave correctly#536
mqcmd196 wants to merge 1 commit intojsk-ros-pkg:masterfrom
mqcmd196:fix-voicevox-shebang

Conversation

@mqcmd196
Copy link
Member

No description provided.

@mqcmd196 mqcmd196 requested a review from iory April 23, 2025 11:51
@k-okada
Copy link
Member

k-okada commented Apr 23, 2025

why?

@knorth55
Copy link
Member

knorth55 commented Apr 23, 2025

@knorth55
Copy link
Member

knorth55 commented Apr 23, 2025

why?

<env name="PATH" value="$(find aques_talk):$(env PATH)" />

this line finds the aques_talk src directory, and it does not load the installed text2wave, I guess.

Copy link
Member

@iory iory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add tests to ensure this change is tested.

@mqcmd196
Copy link
Member Author

BTW, voicevox only supports Python 3, so I think rewriting shebang is fine. What do you think?

@k-okada
Copy link
Member

k-okada commented Apr 24, 2025

maybe you're using wrong version. shebang is already python3

https://github.com/jsk-ros-pkg/jsk_3rdparty/blob/master/3rdparty/voicevox/bin/text2wave#L1

@mqcmd196
Copy link
Member Author

Oh, I misunderstood something. Thank you.

@mqcmd196 mqcmd196 closed this Apr 24, 2025
@mqcmd196 mqcmd196 deleted the fix-voicevox-shebang branch April 24, 2025 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants