[respeaker_ros] change frames_per_buffer for webrtcvad#560
Merged
k-okada merged 1 commit intojsk-ros-pkg:masterfrom Oct 22, 2025
Merged
[respeaker_ros] change frames_per_buffer for webrtcvad#560k-okada merged 1 commit intojsk-ros-pkg:masterfrom
k-okada merged 1 commit intojsk-ros-pkg:masterfrom
Conversation
21c9b5d to
77c0e12
Compare
iory
approved these changes
Oct 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
矢野倉先生に見ていただき、
webrtcvadは小さいサイズのフレームを想定しているが、respeaker_rosのほうでframe sizeが大きかったため、webrtcvadでの処理ができず、エラーが出ていた。
そこで、respeaker_rosでframe sizeを小さく設定できるように変更している。