-
Notifications
You must be signed in to change notification settings - Fork 95
add fetch_ros in jsk_fetch.rosinstall.indigo #1148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
708yamaguchi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is fetch_ros also needed in jsk_fetch_user.rosinstall.indigo?
https://github.com/jsk-ros-pkg/jsk_robot/blob/master/jsk_fetch_robot/jsk_fetch_user.rosinstall.indigo
Currently, jsk_fetch_user.rosinstall.kinetic includes fetch_ros.
https://github.com/jsk-ros-pkg/jsk_robot/blob/master/jsk_fetch_robot/jsk_fetch_user.rosinstall.kinetic#L20-L23
|
for users, i have no idea.
navigation nodes are used in fetch inside so it doesn’t matter, i think
2019年10月20日(日) 2:11 Naoya Yamaguchi <[email protected]>:
***@***.**** commented on this pull request.
Is fetch_ros also needed in jsk_fetch_user.rosinstall.indigo?
https://github.com/jsk-ros-pkg/jsk_robot/blob/master/jsk_fetch_robot/jsk_fetch_user.rosinstall.indigo
Currently, jsk_fetch_user.rosinstall.kinetic includes fetch_ros.
https://github.com/jsk-ros-pkg/jsk_robot/blob/master/jsk_fetch_robot/jsk_fetch_user.rosinstall.kinetic#L20-L23
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1148?email_source=notifications&email_token=ACG6QX4E5CSOQDBN7WXAQWDQPM5VVA5CNFSM4JCC47M2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCIRBD7Y#pullrequestreview-304222719>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACG6QX7UB4HHDDPXUTJ46GDQPM5VVANCNFSM4JCC47MQ>
.
--
--
Shingo Kitagawa
the University of Tokyo, JSK Lab
[email protected]
|
|
OK, I think this PR can be merged. I will create another PR to include |
k-okada
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
because we already upgrade fetch internal PC, do we still need this? @708yamaguchi
|
I think we can keep this rosinstall in |
|
should we create jsk_fetch_robot.rosinstall.indigo? |
maybe we should create |
|
sorry I can not resolve conflicts.... @708yamaguchi |
61267d6 to
452a18f
Compare
fetch_ros is not released in Indigo, so we need to install it manually.