Skip to content

Comments

[jsk_fetch_startup] Fix description report-light-on#1679

Closed
tkmtnt7000 wants to merge 354 commits intojsk-ros-pkg:develop/fetchfrom
tkmtnt7000:PR-fix-description-report-light-on
Closed

[jsk_fetch_startup] Fix description report-light-on#1679
tkmtnt7000 wants to merge 354 commits intojsk-ros-pkg:develop/fetchfrom
tkmtnt7000:PR-fix-description-report-light-on

Conversation

@tkmtnt7000
Copy link
Member

@tkmtnt7000 tkmtnt7000 commented Oct 19, 2022

Thanks to knorth55#343 (comment).

Fix description in report-light-on.

@tkmtnt7000 tkmtnt7000 force-pushed the PR-fix-description-report-light-on branch from 45a7520 to 85d1c0a Compare October 19, 2022 06:30
tkmtnt7000
tkmtnt7000 commented Oct 19, 2022
View reviewed changes
Copy link
Member Author

@tkmtnt7000 tkmtnt7000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Memo:
Use jsk-ros-pkg/jsk_roseus#724

@tkmtnt7000 tkmtnt7000 changed the title [jsk_fetch_startup] Fix description report-light-on [WIP] [jsk_fetch_startup] Fix description report-light-on Oct 19, 2022
@knorth55
Copy link
Member

knorth55 commented Oct 19, 2022

I update jsk-ros-pkg/jsk_roseus#724 and merged into knorth55/jsk_roseus@fetch15 branch.
jsk-ros-pkg/jsk_roseus#715

Now, you can use userdata instead of mydata.
Also, with before-hook-func, you dont need these two lines. https://github.com/jsk-ros-pkg/jsk_robot/pull/1679/files#diff-db470e8365f9cf73b75d39c7822ddc1513068c80cf3e12dd4a3127cba08d2863R771-R772

@knorth55 knorth55 added fetch15 hacktoberfest-accepted https://hacktoberfest.digitalocean.com/hacktoberfest-update fetch1075 develop/fetch labels Oct 19, 2022
@tkmtnt7000 tkmtnt7000 force-pushed the PR-fix-description-report-light-on branch from d70ffc7 to 1e4ddad Compare October 20, 2022 01:11
@tkmtnt7000 tkmtnt7000 changed the title [WIP] [jsk_fetch_startup] Fix description report-light-on [jsk_fetch_startup] Fix description report-light-on Oct 20, 2022
@tkmtnt7000
Copy link
Member Author

tkmtnt7000 commented Oct 20, 2022

Thank you for advice!
I think it's ready to review.

knorth55
knorth55 requested changes Oct 20, 2022
View reviewed changes
sktometometo and others added 16 commits October 24, 2022 23:16
@sktometometo @knorth55
[jsk_fetch_robot][jsk_fetch_startup] support development version of f…
bd16dd5 
…etch_open_auto_dock
@mqcmd196 @knorth55
show hint of trashbins
bdd8fc1
@mqcmd196 @knorth55
publish trashbin candidates
995c52d
@708yamaguchi @knorth55
Automatically bind rfcomm devices when booting fetch
5c67d06
@mqcmd196 @knorth55
use cropbox and detect whether pointclouds over the height of the con…
7f8b553 
…tainer
@mqcmd196 @knorth55
change output message type, use boundingboxarray
b0074e0
@mqcmd196 @knorth55
modify name space
724b871
@708yamaguchi @knorth55
Publish CO2 concentration in go-to-kitchen app
9ace45a
@mqcmd196 @knorth55
add TODO
03c84f8
@tkmtnt7000 @knorth55
[jsk_fetch_startup] Add take-photo function
fa3f023
@tkmtnt7000 @knorth55
[jsk_fetch_startup] Add trashcan_inside picture
0e47f04
@tkmtnt7000 @knorth55
Add trashcan occupancy detection to navigation-utils.l
cab64f2
@tkmtnt7000 @knorth55
Add trashcan occupancy detection to go_to_kitchen.xml
45ae117
@tkmtnt7000 @knorth55
not displaying burnable_trashbin_label_extractor window as default
f51b648
@tkmtnt7000 @knorth55
fix topic name and topic method
4ad0e71
@tkmtnt7000 @knorth55
update notify text
11641fd
knorth55 and others added 15 commits October 24, 2022 23:18
@knorth55
refactor and add launch_* args in fetch_bringup
8d95fbc
@knorth55
update fetch_gazebo_bringup.launch
c3168d6
@sktometometo @knorth55
[jsk_fetch_startup] update move_base parameter for recovery behavior
ae02366
@sktometometo @knorth55
[jsk_fetch_startup] add update_move_base_parameter_recovery to depend…
58cff50 
…encies
@sktometometo @knorth55
[jsk_fetch_startup] update timeout duration for update_move_base_para…
fd272c5 
…meter_recovery
@sktometometo @knorth55
[jsk_fetch_startup] update recovery behavior conf for fetch1075
dc80746
@sktometometo @knorth55
[jsk_fetch_startup] add global config update recovery to complex reco…
6251783 
…very
@knorth55
change node name to smach_to_mail
a216511
@knorth55
add smach_to_mail param
ad56549
@sktometometo @knorth55
[jsk_fetch_startup] add side hook to fetch model
eb0bf3f
@sktometometo @knorth55
[jsk_fetch_accessories] add finger_tip_collision
bb2a248
@sktometometo @knorth55
[jsk_fetch_startup] add finger_tip to fetch model
f4cc087
@sktometometo @knorth55
[jsk_fetch_startup] fix parameters of finger_tip.urdf.xacro
4e1ea8b
@sktometometo @knorth55
[jsk_fetch_startup] update parameter of side_hook.urdf.xacro
3752a9b
@knorth55
add spin-once before image set-alist
dd4249a
@tkmtnt7000 tkmtnt7000 force-pushed the PR-fix-description-report-light-on branch from 4a82cd4 to 8ddcf92 Compare October 26, 2022 05:03
@sktometometo
Copy link
Contributor

sktometometo commented Jun 22, 2023

@tkmtnt7000 Is this PR still valid? If so, could you rebase this PR to current develop/fetch?

@tkmtnt7000
Copy link
Member Author

tkmtnt7000 commented Jun 22, 2023

I think d69d852 and 8ddcf92 have not merged yet, but this feature is not used now. So I'll close this PR.

@tkmtnt7000 tkmtnt7000 closed this Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@knorth55 knorth55 knorth55 requested changes

Assignees

No one assigned

Labels

develop/fetch Fetch fetch15 fetch1075 hacktoberfest-accepted https://hacktoberfest.digitalocean.com/hacktoberfest-update

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@tkmtnt7000 @knorth55 @sktometometo @mqcmd196 @708yamaguchi @Affonso-Gui @iory @nakane11 @MiyabiTane