Skip to content

[jsk_fetch_startup] Add ros_google_cloud_language to fetch_bringup.launch#1791

Merged
tkmtnt7000 merged 2 commits intojsk-ros-pkg:develop/fetchfrom
tkmtnt7000:PR-add-analyze-test-launch
Apr 17, 2023
Merged

[jsk_fetch_startup] Add ros_google_cloud_language to fetch_bringup.launch#1791
tkmtnt7000 merged 2 commits intojsk-ros-pkg:develop/fetchfrom
tkmtnt7000:PR-add-analyze-test-launch

Conversation

@tkmtnt7000
Copy link
Copy Markdown
Member

This PR adds ros_google_cloud_launguage to default fetch_bringup.launch.

This enables us to realize jsk-ros-pkg/jsk_demos#1388 in fetch robot every day.


<include if="$(arg launch_google_analyze_text)"
file="$(find ros_google_cloud_language)/launch/analyze_text.launch">
<arg name="google_cloud_credentials_json" value="/var/lib/robot/eternal-byte-236613-4bc6962824d1.json" />
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tkmtnt7000 Can you upload this credential to GoogleDrive and add link to it here?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I added it in bc3dbd2.

@tkmtnt7000 tkmtnt7000 merged commit 6fd00f5 into jsk-ros-pkg:develop/fetch Apr 17, 2023
@tkmtnt7000 tkmtnt7000 deleted the PR-add-analyze-test-launch branch April 17, 2023 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants