[roseus_smach] fix T/NIL pickling to visualize userdata with smach_viewer#757
[roseus_smach] fix T/NIL pickling to visualize userdata with smach_viewer#757mqcmd196 wants to merge 7 commits intojsk-ros-pkg:masterfrom
Conversation
|
You can test this like terminal 1 roscoreterminal 2 rosrun smach_viewer smach_viewer.pyterminal 3 rosrun roseus_smach state-machine-ros-sample.l --args '(exec-smach-userdata-bool)'Without 9289e6a, 2025-03-06.134043.mp4 |
|
I'm unsure whether the T/NIL in userdata worked with the current master even in Python2 environment |
|
I remember it was working correctly with https://github.com/knorth55/rmui/blob/master/rmuieus/euslisp/common/common-statenet-server.l |
|
Without 9289e6a and check the topic. The local_data is regarded as invalid when decoded with 'utf-8'. I confirmed there are no errors in the melodic environment. |
|
Just note for me and prediction. Both overs ASCII range. I think the message loses the original byte info when converted to a Python ROS message. The error log is generated at https://github.com/ros/genpy/blob/f70658f2200dfb7c98e99e9cf15be61cfaa1a432/src/genpy/message.py#L91 . Maybe there are two options: |
3b95687 to
68e154e
Compare
68e154e to
75f6446
Compare
|
hmm, ? |
smach_viewercannot visualize userdata with T/NIL in current roseus_smach pickle implementation. I don't know whether I should fixroseus_smachorsmach_viewer, but at least this patch works with the currentsmach_viewer.Is #755 needed to test this?