Add 7 packages#14
Merged
kemitchell merged 2 commits intojslicense:mainfrom Dec 9, 2024
ericcornelissen:patch-1
Merged
Conversation
Checked all versions individually. Notably the first two versions of the jsonp package shipped without any license statement, hence they're omitted. For atomically I only bothered to check the v2 release line, not v1.
kemitchell
requested changes
Dec 4, 2024
Co-authored-by: Kyle E. Mitchell <kyle@kemitchell.com>
kemitchell
approved these changes
Dec 9, 2024
Member
kemitchell
left a comment
There was a problem hiding this comment.
I'm exhausted, and not really up to checking this all from scratch again. But I think we hit all the initial feedback I had, I'd rather just release and go back and fix things later if there's some kind of nuanced issue, and, most importantly, I don't want to block this very appreciated contribution!
Member
|
Published as 1.7.0. |
Member
|
Thanks so much for this, @ericcornelissen. I hope some of the other data in this package has been useful to you. |
Contributor
Author
It has been 🙂 Thanks a lot for the project! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
README,LICENSE,COPYING, and header comments for conflicting or additional licenses.fgrep -ir license $PACKAGE_DIRECTORY.Notably
@andrewbranch/untar.jshas an ambiguous license deceleration inuntar.js.atomicallyI only bothered to check the v2 release line, not v1.jsonpwere shipped without any license statement (hence they're omitted).See also:
package.jsonandrewbranch/untar.js#1licenseproperty topackage.jsonfabiospampinato/stubborn-fs#3licenseproperty topackage.jsonfabiospampinato/when-exit#4