Open
Conversation
benjaoming
approved these changes
Mar 5, 2026
Contributor
benjaoming
left a comment
benjaoming
left a comment
There was a problem hiding this comment.
Thanks for doing this! LGTM 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the test matrix such that it now only tests versions of Python and Django that are still receiving upstream support.
It also moves to using a guaranteed-unregistered domain for the
connection-errorsandconnection-errors-redistest cache backends. The previous host was actually resolving for reasons that I suspect aren't all that uncommon: single-label hostnames resolve to my gateway as a fallback. This was causing the raised exception to be different to the one that the 'fail open' code was expecting, so the tests failed.