-
Notifications
You must be signed in to change notification settings - Fork 112
Service requires config, config file restarts service on change #154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cheyngoodman
wants to merge
1
commit into
jsok:master
Choose a base branch
from
cheyngoodman:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgevaert
added a commit
to UGent-DICT/puppet-vault
that referenced
this pull request
Sep 7, 2020
rgevaert
added a commit
to UGent-DICT/puppet-vault
that referenced
this pull request
Sep 7, 2020
rgevaert
added a commit
to UGent-DICT/puppet-vault
that referenced
this pull request
Sep 8, 2020
Closes jsok/pull/154 Closes jsok/puppet-vault/issues/63
rgevaert
added a commit
to UGent-DICT/puppet-vault
that referenced
this pull request
Sep 8, 2020
Closes jsok/pull/154 Closes jsok/puppet-vault/issues/63
rgevaert
added a commit
to UGent-DICT/puppet-vault
that referenced
this pull request
Sep 8, 2020
Closes jsok/pull/154 Closes jsok/puppet-vault/issues/63
rgevaert
added a commit
to UGent-DICT/puppet-vault
that referenced
this pull request
Sep 8, 2020
Closes jsok/pull/154 Closes jsok/puppet-vault/issues/63
rgevaert
added a commit
to UGent-DICT/puppet-vault
that referenced
this pull request
Sep 8, 2020
Closes jsok/pull/154 Closes jsok/puppet-vault/issues/63
rgevaert
added a commit
to UGent-DICT/puppet-vault
that referenced
this pull request
Dec 9, 2020
Closes jsok/pull/154 Closes jsok/puppet-vault/issues/63
jeffbyrnes
pushed a commit
to athenahealth/puppet-vault
that referenced
this pull request
Oct 12, 2022
jeffbyrnes
pushed a commit
to athenahealth/puppet-vault
that referenced
this pull request
Oct 12, 2022
jeffbyrnes
pushed a commit
to athenahealth/puppet-vault
that referenced
this pull request
Oct 20, 2022
jeffbyrnes
pushed a commit
to athenahealth/puppet-vault
that referenced
this pull request
Oct 20, 2022
rgevaert
added a commit
to UGent-DICT/puppet-vault
that referenced
this pull request
Oct 28, 2022
Closes jsok/pull/154 Closes jsok/puppet-vault/issues/63
rgevaert
added a commit
to UGent-DICT/puppet-vault
that referenced
this pull request
Nov 21, 2022
Closes jsok/pull/154 Closes jsok/puppet-vault/issues/63
jonasdemoor
pushed a commit
to UGent-DICT/puppet-vault
that referenced
this pull request
Dec 14, 2022
Closes jsok/pull/154 Closes jsok/puppet-vault/issues/63
bastelfreak
pushed a commit
to bastelfreak/puppet-vault
that referenced
this pull request
Feb 24, 2023
Closes jsok/pull/154 Closes jsok/puppet-vault/issues/63
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Service does not restart when config file changes.
I noticed this when adding
api_addr
setting, the config file was updated but the service did not restart automatically.Adding this notify statement ensures the service will be refreshed, the requirement statement ensures the config file exists before starting or refreshing the service.
TESTS/SPECS