Skip to content

Refactorings for JSON:API extensions to unblock OpenAPI support #1629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 11, 2024

Provide internal hook to replace ResourceObjectConverter once the res…

3840fcb
Select commit
Loading
Failed to load commit list.
Merged

Refactorings for JSON:API extensions to unblock OpenAPI support #1629

Provide internal hook to replace ResourceObjectConverter once the res…
3840fcb
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 11, 2024 in 0s

90.73% (+0.01%) compared to 43c1a4b

View this Pull Request on Codecov

90.73% (+0.01%) compared to 43c1a4b

Details

Codecov Report

Attention: Patch coverage is 90.66667% with 7 lines in your changes missing coverage. Please review.

Project coverage is 90.73%. Comparing base (43c1a4b) to head (3840fcb).

Files with missing lines Patch % Lines
...lization/JsonConverters/ResourceObjectConverter.cs 92.50% 1 Missing and 2 partials ⚠️
.../JsonApiDotNetCore/Middleware/JsonApiMiddleware.cs 33.33% 0 Missing and 2 partials ⚠️
...c/JsonApiDotNetCore/Middleware/JsonApiMediaType.cs 88.88% 1 Missing ⚠️
...DotNetCore/Middleware/JsonApiMediaTypeExtension.cs 75.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1629      +/-   ##
==========================================
+ Coverage   90.72%   90.73%   +0.01%     
==========================================
  Files         352      353       +1     
  Lines       11447    11492      +45     
  Branches     1881     1888       +7     
==========================================
+ Hits        10385    10427      +42     
- Misses        695      696       +1     
- Partials      367      369       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov