Skip to content

draft-next drop tests asserting empty fragments in $id are valid #716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

draft-next drop tests asserting empty fragments in $id are valid #716

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
67 changes: 0 additions & 67 deletions tests/draft-next/id.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,48 +107,6 @@
}
]
},
{
"description": "Valid use of empty fragments in location-independent $id",
"comment": "These are allowed but discouraged",
"schema": {
"$schema": "https://json-schema.org/draft/next/schema",
"$ref": "https://json-schema.org/draft/next/schema"
},
"tests": [
{
"description": "Identifier name with absolute URI",
"data": {
"$ref": "http://localhost:1234/draft-next/bar",
"$defs": {
"A": {
"$id": "http://localhost:1234/draft-next/bar#",
"type": "integer"
}
}
},
"valid": true
},
{
"description": "Identifier name with base URI change in subschema",
"data": {
"$id": "http://localhost:1234/draft-next/root",
"$ref": "http://localhost:1234/draft-next/nested.json#/$defs/B",
"$defs": {
"A": {
"$id": "nested.json",
"$defs": {
"B": {
"$id": "#",
"type": "integer"
}
}
}
}
},
"valid": true
}
]
},
{
"description": "Unnormalized $ids are allowed but discouraged",
"schema": {
Expand Down Expand Up @@ -180,31 +138,6 @@
}
},
"valid": true
},
{
"description": "Unnormalized identifier with empty fragment",
"data": {
"$ref": "http://localhost:1234/draft-next/foo/baz",
"$defs": {
"A": {
"$id": "http://localhost:1234/draft-next/foo/bar/../baz#",
"type": "integer"
}
}
},
"valid": true
},
{
"description": "Unnormalized identifier with empty fragment and no ref",
"data": {
"$defs": {
"A": {
"$id": "http://localhost:1234/draft-next/foo/bar/../baz#",
"type": "integer"
}
}
},
"valid": true
}
]
}
Expand Down